Issue 3505 - Fixed: Issue reporter calls String.replace() with deprecated flags parameter

chrome/content/ui/sendReport.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2015 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 361 matching lines @@
 
     // Init canvas settings
     context.fillStyle = "rgb(0, 0, 0)";
     context.strokeStyle = "rgba(255, 0, 0, 0.7)";
     context.lineWidth = 3;
     context.lineJoin = "round";
   },
 
   get enabled()
   {
-    return this._enabled
+    return this._enabled;
   },
   set enabled(enabled)
   {
     if (this._enabled == enabled)
       return;
 
     this._enabled = enabled;
     this._canvas.style.opacity = this._enabled ? "" : "0.3"
     E("screenshotMarkButton").disabled = !this._enabled;
     E("screenshotRemoveButton").disabled = !this._enabled;
     E("screenshotUndoButton").disabled = !this._enabled || !this._undoQueue.length;
   },
 
   get selectionType()
   {
-    return this._selectionType
+    return this._selectionType;
   },
   set selectionType(type)
   {
     if (this._selectionType == type)
       return;
 
     // Abort selection already in progress
     this.abortSelection();
 
     this._selectionType = type;
@@ skipping 203 matching lines @@
       {
         let file = FileUtils.getDir(pathID, [], false);
         censored[file.path.replace(/[\\\/]+$/, '')] = placeholder;
         let uri = Utils.ioService.newFileURI(file);
         censored[uri.spec.replace(/[\\\/]+$/, '')] = placeholder;
       } catch(e) {}
     }
 
     function str2regexp(str, flags)
     {
-      return new RegExp(str.replace(/(\W)/g, "\\$1"), flags);

[Thomas Greiner, 2016/01/12 17:53:39]

You can avoid the creation of the capturing group by using "\\$&" instead.

[Wladimir Palant, 2016/01/12 17:59:12]

Done.

+      return new RegExp(str.replace(/\W/g, "\\$&"), flags);
     }
 
     let errors = reportElement("errors");
     for (let i = 0; i < messages.length; i++)
     {
       let message = messages[i];
 
       let text = message.errorMessage;
       for (let path in censored)
         text = text.replace(str2regexp(path, "gi"), censored[path]);
@@ skipping 921 matching lines @@
 
 function censorURL(url)
 {
   return url.replace(/([?;&\/#][^?;&\/#]+?=)[^?;&\/#]+/g, "$1*");
 }
 
 function encodeHTML(str)
 {
   return str.replace(/&/g, "&amp;").replace(/</g, "&lt;").replace(/>/g, "&gt;").replace(/"/g, "&quot;");
 }