Issue 3516 - Add support for optional permissions

packagerChrome.py

 # coding: utf-8
 
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 import sys
 import os
 import re
 import json
@@ skipping 82 matching lines @@
     templateData[opt] = {'icon': icon, 'popup': popup}
 
   if metadata.has_option('general', 'icons'):
     templateData['icons'] = makeIcons(files, metadata.get('general', 'icons').split())
 
   if metadata.has_option('general', 'permissions'):
     templateData['permissions'] = re.split(r'\s+', metadata.get('general', 'permissions'))
     if params['experimentalAPI']:
       templateData['permissions'].append('experimental')
 
+  if metadata.has_option('general', 'optionalPermissions'):
+    templateData['optionalPermissions'] = re.split(

[Sebastian Noack, 2016/01/14 16:26:11]

Note that re.split(r'\s+', s) is equivalent to s.split()

[kzar, 2016/01/14 16:39:07]

I know, just staying consistent with the surrounding code. Prefer I change it?

[Sebastian Noack, 2016/01/14 16:41:54]

Feel free to change it in the other places as well.

+      r'\s+', metadata.get('general', 'optionalPermissions')
+    )
+
   if metadata.has_option('general', 'backgroundScripts'):
     templateData['backgroundScripts'] = re.split(r'\s+', metadata.get('general', 'backgroundScripts'))
     if params['devenv']:
       templateData['backgroundScripts'].append('devenvPoller__.js')
 
   if metadata.has_option('general', 'webAccessible') and metadata.get('general', 'webAccessible') != '':
     templateData['webAccessible'] = re.split(r'\s+', metadata.get('general', 'webAccessible'))
 
   if metadata.has_section('contentScripts'):
     contentScripts = []
@@ skipping 255 matching lines @@
     files['qunit/index.html'] = createScriptPage(params, 'testIndex.html.tmpl',
                                                  ('general', 'testScripts'))
 
   zipdata = files.zipToString()
   signature = None
   pubkey = None
   if keyFile != None:
     signature = signBinary(zipdata, keyFile)
     pubkey = getPublicKey(keyFile)
   writePackage(outFile, pubkey, signature, zipdata)