Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29333461: Issue 3516 - Add support for optional permissions (Closed)

Created:
Jan. 14, 2016, 4:21 p.m. by kzar
Modified:
Jan. 14, 2016, 5:22 p.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 3516 - Add support for optional permissions

Patch Set 1 #

Total comments: 3

Patch Set 2 : Change re.split to .split #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M manifest.json.tmpl View 1 chunk +4 lines, -0 lines 0 comments Download
M packagerChrome.py View 1 5 chunks +15 lines, -8 lines 0 comments Download

Messages

Total messages: 6
kzar
Patch Set 1
Jan. 14, 2016, 4:22 p.m. (2016-01-14 16:22:35 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29333461/diff/29333462/packagerChrome.py File packagerChrome.py (right): https://codereview.adblockplus.org/29333461/diff/29333462/packagerChrome.py#newcode104 packagerChrome.py:104: templateData['optionalPermissions'] = re.split( Note that re.split(r'\s+', s) is equivalent ...
Jan. 14, 2016, 4:26 p.m. (2016-01-14 16:26:12 UTC) #2
kzar
https://codereview.adblockplus.org/29333461/diff/29333462/packagerChrome.py File packagerChrome.py (right): https://codereview.adblockplus.org/29333461/diff/29333462/packagerChrome.py#newcode104 packagerChrome.py:104: templateData['optionalPermissions'] = re.split( On 2016/01/14 16:26:11, Sebastian Noack wrote: ...
Jan. 14, 2016, 4:39 p.m. (2016-01-14 16:39:07 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29333461/diff/29333462/packagerChrome.py File packagerChrome.py (right): https://codereview.adblockplus.org/29333461/diff/29333462/packagerChrome.py#newcode104 packagerChrome.py:104: templateData['optionalPermissions'] = re.split( On 2016/01/14 16:39:07, kzar wrote: > ...
Jan. 14, 2016, 4:41 p.m. (2016-01-14 16:41:54 UTC) #4
kzar
Patch Set 2 : Change re.split to .split
Jan. 14, 2016, 5:02 p.m. (2016-01-14 17:02:12 UTC) #5
Sebastian Noack
Jan. 14, 2016, 5:08 p.m. (2016-01-14 17:08:26 UTC) #6
LGTM, but you mind want to commit the changes replacing re.split everywhere,
separately.

Powered by Google App Engine
This is Rietveld