Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29333538: Issue 3515 - Remove outdated hack ignoring sub-directories in lib/ (Closed)

Created:
Jan. 14, 2016, 5:30 p.m. by Sebastian Noack
Modified:
Jan. 15, 2016, 1:19 p.m.
Reviewers:
kzar, Wladimir Palant
Visibility:
Public.

Description

According to Wladimir this hack was introduced to work around an issue with past Opera builds. This issue doesn't exist anymore. Also, besides being outdated, this hack currently prevents us from putting the polyfills under lib/polyfill/.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use set instead list #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M packagerChrome.py View 1 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
Jan. 14, 2016, 5:59 p.m. (2016-01-14 17:59:42 UTC) #1
Wladimir Palant
https://codereview.adblockplus.org/29333538/diff/29333539/packagerChrome.py File packagerChrome.py (right): https://codereview.adblockplus.org/29333538/diff/29333539/packagerChrome.py#newcode21 packagerChrome.py:21: return ['store.description'] This should still be a set - ...
Jan. 14, 2016, 7:28 p.m. (2016-01-14 19:28:04 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29333538/diff/29333539/packagerChrome.py File packagerChrome.py (right): https://codereview.adblockplus.org/29333538/diff/29333539/packagerChrome.py#newcode21 packagerChrome.py:21: return ['store.description'] On 2016/01/14 19:28:04, Wladimir Palant wrote: > ...
Jan. 14, 2016, 11:28 p.m. (2016-01-14 23:28:41 UTC) #3
Wladimir Palant
Jan. 15, 2016, 12:49 p.m. (2016-01-15 12:49:22 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld