Issue 29333538: Issue 3515 - Remove outdated hack ignoring sub-directories in lib/

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29333538: Issue 3515 - Remove outdated hack ignoring sub-directories in lib/ (Closed)

Created:
Jan. 14, 2016, 5:30 p.m. by Sebastian Noack

Modified:
Jan. 15, 2016, 1:19 p.m.

Reviewers:
kzar, Wladimir Palant

Visibility:
Public.

Description

According to Wladimir this hack was introduced to work around an issue with past Opera builds. This issue doesn't exist anymore. Also, besides being outdated, this hack currently prevents us from putting the polyfills under lib/polyfill/.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use set instead list #

Created: Jan. 14, 2016, 11:28 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -8 lines)			Patch
	M	packagerChrome.py	View	1	1 chunk	+1 line, -8 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Wladimir Palant

https://codereview.adblockplus.org/29333538/diff/29333539/packagerChrome.py File packagerChrome.py (right): https://codereview.adblockplus.org/29333538/diff/29333539/packagerChrome.py#newcode21 packagerChrome.py:21: return ['store.description'] This should still be a set - ...

Jan. 14, 2016, 7:28 p.m. (2016-01-14 19:28:04 UTC) #2

Sebastian Noack

Jan. 14, 2016, 11:28 p.m. (2016-01-14 23:28:41 UTC) #3

LGTM

Expand All Messages | Collapse All Messages