Unified Diff: background.js
Issue 29334223:
Issue 3532 - Generate animation images at runtime (Closed)
Patch Set:
Created Jan. 21, 2016, 5:35 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
lib/icon.js » ('j')
|
lib/icon.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: background.js |
| diff --git a/background.js b/background.js |
| index a3792acd5f0fd7ba07920482b662acafeff011ad..5e6b68f660fe89c6cd72d1bb537574784ded9a1f 100644 |
| --- a/background.js |
| +++ b/background.js |
| @@ -127,7 +127,7 @@ var contextMenuItem = { |
| function refreshIconAndContextMenu(page) |
| { |
| var whitelisted = isPageWhitelisted(page); |
| - updateIcon(page, whitelisted); |
| + updateIcon(page, whitelisted && true || false); |
|
Sebastian Noack
2016/01/21 18:11:01
Why mind casting to bool here?
kzar
2016/01/21 21:07:30
Because the documentation for updateIcon says it e
Sebastian Noack
2016/01/22 15:59:15
Well, documented type annotations or not, JavaScri
kzar
2016/01/22 16:49:34
Ok, I'll just remove this change.
|
| // show or hide the context menu entry dependent on whether |
| // adblocking is active on that page |
