Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29334229: Issue 3532 - Stop generating animation images at build time (Closed)

Created:
Jan. 21, 2016, 6:07 p.m. by kzar
Modified:
Jan. 26, 2016, 11:17 p.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 3532 - Stop generating animation images at build time

Patch Set 1 #

Patch Set 2 : Don't bother generate Safari icons at buildtime #

Patch Set 3 : Removed imageCompression.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -199 lines) Patch
D imageCompression.py View 1 2 1 chunk +0 lines, -82 lines 0 comments Download
M imageConversion.py View 1 1 chunk +0 lines, -109 lines 0 comments Download
M packagerChrome.py View 1 chunk +0 lines, -4 lines 0 comments Download
M packagerSafari.py View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5
kzar
Patch Set 1
Jan. 21, 2016, 6:08 p.m. (2016-01-21 18:08:29 UTC) #1
kzar
Patch Set 2 : Don't bother generate Safari icons at buildtime
Jan. 21, 2016, 10:49 p.m. (2016-01-21 22:49:21 UTC) #2
Sebastian Noack
What's about imageCompression.py? It was used to compress the generated/converted images with pngout (if installed). ...
Jan. 22, 2016, 3:29 p.m. (2016-01-22 15:29:22 UTC) #3
kzar
Patch Set 3 : Removed imageCompression.py
Jan. 22, 2016, 3:53 p.m. (2016-01-22 15:53:24 UTC) #4
Sebastian Noack
Jan. 22, 2016, 4:11 p.m. (2016-01-22 16:11:36 UTC) #5
LGTM.

But don't push before the related changes of the extension code landed! (The
nightlies always use the latest buildtools version regardless of the dependency
revision)

Powered by Google App Engine
This is Rietveld