Issue 29334229: Issue 3532 - Stop generating animation images at build time

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29334229: Issue 3532 - Stop generating animation images at build time (Closed)

Created:
Jan. 21, 2016, 6:07 p.m. by kzar

Modified:
Jan. 26, 2016, 11:17 p.m.

Reviewers:
Sebastian Noack

Visibility:
Public.

Description

Issue 3532 - Stop generating animation images at build time

Patch Set 1 #

Patch Set 2 : Don't bother generate Safari icons at buildtime #

Patch Set 3 : Removed imageCompression.py #

Created: Jan. 22, 2016, 3:50 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -199 lines)			Patch
D	imageCompression.py	View	1 2	1 chunk	+0 lines, -82 lines	0 comments	Download
M	imageConversion.py	View	1	1 chunk	+0 lines, -109 lines	0 comments	Download
M	packagerChrome.py	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	packagerSafari.py	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

kzar

Patch Set 2 : Don't bother generate Safari icons at buildtime

Jan. 21, 2016, 10:49 p.m. (2016-01-21 22:49:21 UTC) #2

Sebastian Noack

What's about imageCompression.py? It was used to compress the generated/converted images with pngout (if installed). ...

Jan. 22, 2016, 3:29 p.m. (2016-01-22 15:29:22 UTC) #3

Sebastian Noack

Jan. 22, 2016, 4:11 p.m. (2016-01-22 16:11:36 UTC) #5

LGTM.

But don't push before the related changes of the extension code landed! (The
nightlies always use the latest buildtools version regardless of the dependency
revision)

Expand All Messages | Collapse All Messages