Issue 3572 - Allowed address reuse for test server

test_server.py

 #!/usr/bin/env python
 
 # This file is part of Adblock Plus <https://adblockplus.org/>,
 # Copyright (C) 2006-2016 Eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 # GNU General Public License for more details.
 #
 # You should have received a copy of the GNU General Public License
 # along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
 
 import os
 import SimpleHTTPServer
 import SocketServer
 
 PORT = ("127.0.0.1", 5000)
 
-httpd = SocketServer.TCPServer(PORT, SimpleHTTPServer.SimpleHTTPRequestHandler, False)
-httpd.allow_reuse_address = True

[saroyanm, 2016/01/29 13:38:08]

You can declare the allow_reuse_address on the class itself and let the
TCPServer constructor to setup binding and call server_activate(), just tested
myself works fine:
https://hg.python.org/cpython/file/2.7/Lib/SocketServer.py#l432

ex.: SocketServer.TCPServer.allow_reuse_address = True
 

[Thomas Greiner, 2016/01/29 18:18:55]

Done.

You're right. Great that you found that.

+SocketServer.TCPServer.allow_reuse_address = True

[Sebastian Noack, 2016/02/02 10:54:21]

I'd rather not monkey-patch the corelib. This will have side effects when using
the TCPServer somewehre else. Sure, that's not much of a concern for a script as
small as this one, but still it's a hack. It would have been better to subclass
TCPServer overridding allow_reuse_address there.

Or even better, simply use BaseHTTPServer.HTTPServer which seems to be more
appropriate here anyway, and already has allow_reuse_address=1.

+httpd = SocketServer.TCPServer(PORT, SimpleHTTPServer.SimpleHTTPRequestHandler)
 
 if __name__ == "__main__":
   print "Starting web server at http://%s:%i/" % PORT
   os.chdir(os.path.dirname(__file__))
-  httpd.server_bind()
-  httpd.server_activate()
   httpd.serve_forever()