Issue 29334529: Issue 3572 - Allowed address reuse for test server

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29334529: Issue 3572 - Allowed address reuse for test server (Closed)

Created:
Jan. 25, 2016, 6:57 p.m. by Thomas Greiner

Modified:
Feb. 2, 2016, 10:54 a.m.

Reviewers:
Sebastian Noack, saroyanm

CC:
Felix Dahlke

Visibility:
Public.

Description

Issue 3572 - Allowed address reuse for test server

Patch Set 2 : #

Total comments: 1

Created: Jan. 29, 2016, 6:16 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	test_server.py	View	1	1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

saroyanm

https://codereview.adblockplus.org/29334529/diff/29334530/test_server.py File test_server.py (right): https://codereview.adblockplus.org/29334529/diff/29334530/test_server.py#newcode25 test_server.py:25: httpd.allow_reuse_address = True You can declare the allow_reuse_address on ...

Jan. 29, 2016, 1:38 p.m. (2016-01-29 13:38:08 UTC) #2

Thomas Greiner

Jan. 29, 2016, 6:18 p.m. (2016-01-29 18:18:55 UTC) #3

Sebastian Noack

Feb. 2, 2016, 10:54 a.m. (2016-02-02 10:54:21 UTC) #5

Message was sent while issue was closed.

https://codereview.adblockplus.org/29334529/diff/29335128/test_server.py
File test_server.py (right):

https://codereview.adblockplus.org/29334529/diff/29335128/test_server.py#newc...
test_server.py:24: SocketServer.TCPServer.allow_reuse_address = True
I'd rather not monkey-patch the corelib. This will have side effects when using
the TCPServer somewehre else. Sure, that's not much of a concern for a script as
small as this one, but still it's a hack. It would have been better to subclass
TCPServer overridding allow_reuse_address there.

Or even better, simply use BaseHTTPServer.HTTPServer which seems to be more
appropriate here anyway, and already has allow_reuse_address=1.

Expand All Messages | Collapse All Messages