Issue 1950 - Fixed: Filter tooltip not shown for long filters

chrome/content/ui/filters-filteractions.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 322 matching lines @@
       event.preventDefault();
       return;
     }
 
     function setMultilineContent(box, text)
     {
       while (box.firstChild)
         box.removeChild(box.firstChild);
 
       let lines = text.match(/.{1,80}/g);
-      if (lines.length > 6)

[Erik, 2016/01/29 04:29:31]

I think this should be  `if (lines.length > 7)` since the logic here would
generate a 7 item array to replace `lines`.

If `lines` is only length 7 then we might as well show all of it.

[Thomas Greiner, 2016/01/29 18:28:55]

Done. I agree that the maximum of 482 characters that's specified in the ticket
should've rather been 560.

+      if (lines.length > 7)
       {
         // Text is too long to display in full so we cut out the middle part
         lines = lines.slice(0,3).concat("\u2026", lines.slice(-3));
       }
 
       for (let line of lines)
       {
         let description = document.createElement("description");
         description.setAttribute("value", line);
         box.appendChild(description);
@@ skipping 201 matching lines @@
       return;
 
     this.deleteItems(this.dragItems);
   }
 };
 
 window.addEventListener("load", function()
 {
   FilterActions.init();
 }, false);