Issue 29334565: Issue 1950 - Fixed: Filter tooltip not shown for long filters

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29334565: Issue 1950 - Fixed: Filter tooltip not shown for long filters (Closed)

Created:
Jan. 26, 2016, 4:11 p.m. by Thomas Greiner

Modified:
Feb. 1, 2016, 12:52 p.m.

Reviewers:
Erik

CC:
Wladimir Palant

Visibility:
Public.

Description

Note that I'm displaying the last three lines instead of the last 240 characters. It doesn't appear to make a big difference but allowed me to simplify the code which is why I chose to differ from the ticket in that regard.

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Created: Jan. 29, 2016, 6:26 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -6 lines)			Patch
	M	chrome/content/ui/filters-filteractions.js	View	1	1 chunk	+10 lines, -3 lines	0 comments	Download
	M	chrome/content/ui/sidebar.js	View	1	1 chunk	+10 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Erik

https://codereview.adblockplus.org/29334565/diff/29334566/chrome/content/ui/filters-filteractions.js File chrome/content/ui/filters-filteractions.js (right): https://codereview.adblockplus.org/29334565/diff/29334566/chrome/content/ui/filters-filteractions.js#newcode343 chrome/content/ui/filters-filteractions.js:343: if (lines.length > 6) I think this should be ...

Jan. 29, 2016, 4:29 a.m. (2016-01-29 04:29:31 UTC) #2

Thomas Greiner

Jan. 29, 2016, 6:28 p.m. (2016-01-29 18:28:56 UTC) #3

LGTM

Expand All Messages | Collapse All Messages