Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: include/AdblockPlus/JsValue.h

Issue 29334678: Issue 3589 - Change return type of AdblockPlus::JsValue::Call from pointer to r-value object. (Closed)
Patch Set: Created Jan. 27, 2016, 11:17 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/FilterEngine.cpp » ('j') | src/FilterEngine.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 * @return Class name of the value. 114 * @return Class name of the value.
115 */ 115 */
116 std::string GetClass() const; 116 std::string GetClass() const;
117 117
118 /** 118 /**
119 * Invokes the value as a function (see `IsFunction()`). 119 * Invokes the value as a function (see `IsFunction()`).
120 * @param params Optional list of parameters. 120 * @param params Optional list of parameters.
121 * @param thisPtr Optional `this` value. 121 * @param thisPtr Optional `this` value.
122 * @return Value returned by the function. 122 * @return Value returned by the function.
123 */ 123 */
124 JsValuePtr Call(const JsValueList& params = JsValueList(), 124 JsValue Call(const JsValueList& params = JsValueList(),
125 AdblockPlus::JsValuePtr thisPtr = AdblockPlus::JsValuePtr()) const; 125 AdblockPlus::JsValuePtr thisPtr = AdblockPlus::JsValuePtr()) const;
126 126
127 v8::Local<v8::Value> UnwrapValue() const; 127 v8::Local<v8::Value> UnwrapValue() const;
128 protected: 128 protected:
129 JsEnginePtr jsEngine; 129 JsEnginePtr jsEngine;
130 private: 130 private:
131 JsValue(JsEnginePtr jsEngine, v8::Handle<v8::Value> value); 131 JsValue(JsEnginePtr jsEngine, v8::Handle<v8::Value> value);
132 void SetProperty(const std::string& name, v8::Handle<v8::Value> val); 132 void SetProperty(const std::string& name, v8::Handle<v8::Value> val);
133 std::unique_ptr<v8::Persistent<v8::Value>> value; 133 std::unique_ptr<v8::Persistent<v8::Value>> value;
134 }; 134 };
135 } 135 }
136 136
137 #endif 137 #endif
OLDNEW
« no previous file with comments | « no previous file | src/FilterEngine.cpp » ('j') | src/FilterEngine.cpp » ('J')

Powered by Google App Engine
This is Rietveld