Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29334678: Issue 3589 - Change return type of AdblockPlus::JsValue::Call from pointer to r-value object. (Closed)

Created:
Jan. 27, 2016, 11:17 a.m. by sergei
Modified:
March 27, 2017, 2:19 p.m.
CC:
Felix Dahlke
Visibility:
Public.

Description

In addition JsValue::Call for a single argument accepts now a `const JsValue&` instead of a pointer.

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -52 lines) Patch
M include/AdblockPlus/JsValue.h View 1 4 chunks +7 lines, -2 lines 0 comments Download
M src/FilterEngine.cpp View 1 10 chunks +20 lines, -21 lines 0 comments Download
M src/JsValue.cpp View 1 2 chunks +31 lines, -23 lines 0 comments Download
M src/Notification.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M test/JsValue.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6
Oleksandr
LGTM https://codereview.adblockplus.org/29334678/diff/29334679/src/FilterEngine.cpp File src/FilterEngine.cpp (right): https://codereview.adblockplus.org/29334678/diff/29334679/src/FilterEngine.cpp#newcode373 src/FilterEngine.cpp:373: return std::make_shared<JsValue>(func->Call(params)); Nit: This reminds me - isn't ...
Jan. 31, 2016, 9:23 p.m. (2016-01-31 21:23:24 UTC) #1
Eric
These changes look OK, but they seem to belong to the review they grew out ...
Feb. 8, 2016, 7:54 p.m. (2016-02-08 19:54:50 UTC) #2
sergei
Adding Hubert. Sorry, forgot about it. I will rebase it after landing of https://codereview.adblockplus.org/29393589/.
March 24, 2017, 2:27 p.m. (2017-03-24 14:27:50 UTC) #3
hub
My patch has landed now.
March 24, 2017, 5:24 p.m. (2017-03-24 17:24:24 UTC) #4
sergei
rebased
March 27, 2017, 9:49 a.m. (2017-03-27 09:49:30 UTC) #5
hub
March 27, 2017, 1:04 p.m. (2017-03-27 13:04:40 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld