Issue 3589 - Change return type of AdblockPlus::JsValue::Call from pointer to r-value object.

include/AdblockPlus/JsValue.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
- * Copyright (C) 2006-2016 Eyeo GmbH
+ * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 #ifndef ADBLOCK_PLUS_JS_VALUE_H
 #define ADBLOCK_PLUS_JS_VALUE_H
 
 #include <stdint.h>
 #include <string>
 #include <vector>
 #include <memory>
 
 namespace v8
 {
   class Value;
+  class Object;
   template<class T> class Handle;
   template<class T> class Local;
   template<class T> class Persistent;
 }
 
 namespace AdblockPlus
 {
   class JsValue;
   class JsEngine;
 
   typedef std::shared_ptr<JsEngine> JsEnginePtr;
 
   /**
    * Shared smart pointer to a `JsValue` instance.
    */
   typedef std::shared_ptr<JsValue> JsValuePtr;
+  typedef std::shared_ptr<const JsValue> JsConstValuePtr;
 
   /**
    * List of JavaScript values.
    */
   typedef std::vector<AdblockPlus::JsValuePtr> JsValueList;
+  typedef std::vector<AdblockPlus::JsConstValuePtr> JsConstValueList;
 
   /**
    * Wrapper for JavaScript values.
    * See `JsEngine` for creating `JsValue` objects.
    */
   class JsValue
   {
     friend class JsEngine;
   public:
     JsValue(JsValue&& src);
@@ skipping 54 matching lines @@
      * @return Class name of the value.
      */
     std::string GetClass() const;
 
     /**
      * Invokes the value as a function (see `IsFunction()`).
      * @param params Optional list of parameters.
      * @param thisPtr Optional `this` value.
      * @return Value returned by the function.
      */
-    JsValue Call(const JsValueList& params = JsValueList(),
+    JsValue Call(const JsConstValueList& params = JsConstValueList(),
         AdblockPlus::JsValuePtr thisPtr = AdblockPlus::JsValuePtr()) const;
+
+    /**
+     * Invokes the value as a function (see `IsFunction()`) with single
+     * parameter.
+     * @param arg A single required parameter.
+     * @return Value returned by the function.
+     */
+    JsValue Call(const JsValue& arg) const;
 
     v8::Local<v8::Value> UnwrapValue() const;
   protected:
     JsEnginePtr jsEngine;
   private:
     JsValue(JsEnginePtr jsEngine, v8::Handle<v8::Value> value);
     void SetProperty(const std::string& name, v8::Handle<v8::Value> val);
+    // Parameter args is not const because a pointer to its internal arrays is
+    // passed to v8::Function::Call but the latter does not expect a const pointer.
+    JsValue Call(std::vector<v8::Handle<v8::Value>>& args, v8::Local<v8::Object> thisObj) const;
+
     std::unique_ptr<v8::Persistent<v8::Value>> value;
   };
 }
 
 #endif