Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: src/Notification.cpp

Issue 29334678: Issue 3589 - Change return type of AdblockPlus::JsValue::Call from pointer to r-value object. (Closed)
Patch Set: Created Jan. 27, 2016, 11:17 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/FilterEngine.cpp ('K') | « src/JsValue.cpp ('k') | test/JsValue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/Notification.cpp
diff --git a/src/Notification.cpp b/src/Notification.cpp
index da5ad0f004276d02c5e49929788e454041de2c1d..f7f11eefde72e9082039c0f6426dee50534c7885 100644
--- a/src/Notification.cpp
+++ b/src/Notification.cpp
@@ -71,14 +71,14 @@ NotificationTexts Notification::GetTexts()
{
JsValueList params;
params.push_back(shared_from_this());
- JsValuePtr jsTexts = jsEngine->Evaluate("API.getNotificationTexts")->Call(params);
+ JsValue jsTexts = jsEngine->Evaluate("API.getNotificationTexts")->Call(params);
NotificationTexts notificationTexts;
- JsValuePtr jsTitle = jsTexts->GetProperty("title");
+ JsValuePtr jsTitle = jsTexts.GetProperty("title");
if (jsTitle->IsString())
{
notificationTexts.title = jsTitle->AsString();
}
- JsValuePtr jsMessage = jsTexts->GetProperty("message");
+ JsValuePtr jsMessage = jsTexts.GetProperty("message");
if (jsMessage->IsString())
{
notificationTexts.message = jsMessage->AsString();
« src/FilterEngine.cpp ('K') | « src/JsValue.cpp ('k') | test/JsValue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld