Side by Side Diff: pages/contributors.html
Issue 29334775:
Issue 2873 - Making contributor tables responsive (Closed)
Patch Set: Fixed whitespace
Created Feb. 5, 2016, 1:31 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| OLD | NEW |
|---|---|
| 1 title=Adblock Plus - Contributor Credits | 1 title=Adblock Plus - Contributor Credits |
| 2 | 2 |
| 3 <head> | 3 <head> |
| 4 <style type="text/css"> | 4 <style type="text/css"> |
| 5 #content | 5 #content |
| 6 { | 6 { |
| 7 width: 980px; | 7 width: 980px; |
| 8 } | 8 } |
| 9 | 9 |
| 10 #pageactions | 10 #pageactions |
| (...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 63 { | 63 { |
| 64 height: 40px; | 64 height: 40px; |
| 65 padding: 10px 0 5px 0; | 65 padding: 10px 0 5px 0; |
| 66 vertical-align: bottom; | 66 vertical-align: bottom; |
| 67 } | 67 } |
| 68 | 68 |
| 69 .contributors-table tbody td | 69 .contributors-table tbody td |
| 70 { | 70 { |
| 71 padding: 5px 5px; | 71 padding: 5px 5px; |
| 72 } | 72 } |
| 73 | |
| 74 @media(max-width: 980px) { | |
| 75 #content | |
| 76 { | |
| 77 width: auto; | |
| 78 } | |
| 79 section | |
| 80 { | |
| 81 display: block; | |
| 82 margin: 0px; | |
| 83 } | |
| 84 .contributors-table | |
| 85 { | |
| 86 width: 100%; | |
| 87 display: table; | |
|
saroyanm
2016/02/05 14:49:58
What about not changing the display value at all ?
juliandoucette
2016/02/05 18:38:24
Done.
| |
| 88 } | |
| 89 .contributors-table td | |
| 90 { | |
| 91 font-size: 12px; | |
|
saroyanm
2016/02/05 14:49:57
I would avoid introducing similar cosmetic fixes,
juliandoucette
2016/02/05 18:38:24
Done.
| |
| 92 min-width: inherit; | |
|
saroyanm
2016/02/05 14:49:57
Deatail: I think no need to inherit initial value,
juliandoucette
2016/02/05 18:38:24
Done.
| |
| 93 width: 50%; | |
| 94 } | |
| 95 } | |
| 96 | |
| 73 </style> | 97 </style> |
| 74 </head> | 98 </head> |
| 75 <section id="team"> | 99 <section id="team"> |
| 76 <h3>{{s1 Team}}</h3> | 100 <h3>{{s1 Team}}</h3> |
| 77 <table class="contributors-table" rules="groups"> | 101 <table class="contributors-table" rules="groups"> |
| 78 <thead> | 102 <thead> |
| 79 <tr> | 103 <tr> |
| 80 <td>{{s2 Name}}</td> | 104 <td>{{s2 Name}}</td> |
| 81 <td>{{s3 Role}}</td> | 105 <td>{{s3 Role}}</td> |
| 82 </tr> | 106 </tr> |
| (...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 250 <td>Nickolay Ponomarev</td> | 274 <td>Nickolay Ponomarev</td> |
| 251 <td>{{s44 Developer (performance)}}</td> | 275 <td>{{s44 Developer (performance)}}</td> |
| 252 </tr> | 276 </tr> |
| 253 <tr> | 277 <tr> |
| 254 <td>Sebastian Schmidt (yath)</td> | 278 <td>Sebastian Schmidt (yath)</td> |
| 255 <td>{{s45 Developer (Adblock Plus for Android bug fix)}}</td> | 279 <td>{{s45 Developer (Adblock Plus for Android bug fix)}}</td> |
| 256 </tr> | 280 </tr> |
| 257 </tbody> | 281 </tbody> |
| 258 </table> | 282 </table> |
| 259 </section> | 283 </section> |
| OLD | NEW |
« no previous file with comments
|
« no previous file
|
no next file »
|
no next file with comments »
