Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29334775: Issue 2873 - Making contributor tables responsive (Closed)

Created:
Jan. 27, 2016, 4:29 p.m. by juliandoucette
Modified:
Feb. 10, 2016, 1:36 p.m.
Reviewers:
saroyanm
CC:
Thomas Greiner
Visibility:
Public.

Description

Issue 2873 - Making contributor tables responsive

Patch Set 1 #

Total comments: 10

Patch Set 2 : Smaller implementation #

Patch Set 3 : Fixed whitespace #

Total comments: 6

Patch Set 4 : Removed unnessisary changes and fixed spacing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M pages/contributors.html View 1 2 3 2 chunks +26 lines, -1 line 0 comments Download

Messages

Total messages: 6
juliandoucette
Jan. 27, 2016, 4:33 p.m. (2016-01-27 16:33:48 UTC) #1
saroyanm
https://codereview.adblockplus.org/29334775/diff/29334776/pages/contributors.html File pages/contributors.html (right): https://codereview.adblockplus.org/29334775/diff/29334776/pages/contributors.html#newcode21 pages/contributors.html:21: margin: 0px 0 10px 0; Detail: please make styling ...
Feb. 4, 2016, 4:03 p.m. (2016-02-04 16:03:46 UTC) #2
juliandoucette
https://codereview.adblockplus.org/29334775/diff/29334776/pages/contributors.html File pages/contributors.html (right): https://codereview.adblockplus.org/29334775/diff/29334776/pages/contributors.html#newcode21 pages/contributors.html:21: margin: 0px 0 10px 0; On 2016/02/04 16:03:45, saroyanm ...
Feb. 5, 2016, 1:30 p.m. (2016-02-05 13:30:26 UTC) #3
saroyanm
https://codereview.adblockplus.org/29334775/diff/29335792/pages/contributors.html File pages/contributors.html (right): https://codereview.adblockplus.org/29334775/diff/29335792/pages/contributors.html#newcode87 pages/contributors.html:87: display: table; What about not changing the display value ...
Feb. 5, 2016, 2:49 p.m. (2016-02-05 14:49:58 UTC) #4
juliandoucette
https://codereview.adblockplus.org/29334775/diff/29335792/pages/contributors.html File pages/contributors.html (right): https://codereview.adblockplus.org/29334775/diff/29335792/pages/contributors.html#newcode87 pages/contributors.html:87: display: table; On 2016/02/05 14:49:58, saroyanm wrote: > What ...
Feb. 5, 2016, 6:38 p.m. (2016-02-05 18:38:24 UTC) #5
saroyanm
Feb. 10, 2016, 11:38 a.m. (2016-02-10 11:38:16 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld