Delta Between Two Patch Sets: pages/contributors.html
Issue 29334775:
Issue 2873 - Making contributor tables responsive (Closed)
Left Patch Set:
Created Jan. 27, 2016, 4:29 p.m.
Right Patch Set: Removed unnessisary changes and fixed spacing
Created Feb. 5, 2016, 6:38 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« no previous file
|
no next file »
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 title=Adblock Plus - Contributor Credits | 1 title=Adblock Plus - Contributor Credits |
| 2 | 2 |
| 3 <head> | 3 <head> |
| 4 <style type="text/css"> | 4 <style type="text/css"> |
| 5 #content | 5 #content |
| 6 { | 6 { |
| 7 position: relative; | 7 width: 980px; |
| 8 overflow: auto; | |
| 9 } | |
| 10 | |
| 11 @media(min-width: 980px) | |
| 12 { | |
| 13 #content | |
| 14 { | |
| 15 width: 980px; | |
| 16 } | |
| 17 } | |
| 18 | |
| 19 #content h3 | |
| 20 { | |
| 21 margin: 0px 0 10px 0; | |
|
saroyanm
2016/02/04 16:03:45
Detail: please make styling consistent by specifin
juliandoucette
2016/02/05 13:30:25
Done.
| |
| 22 } | 8 } |
| 23 | 9 |
| 24 #pageactions | 10 #pageactions |
| 25 { | 11 { |
| 26 margin-left: 0; | 12 margin-left: 0; |
| 27 margin-right: 0; | 13 margin-right: 0; |
| 28 width: 100%; | 14 width: 100%; |
| 29 } | 15 } |
| 30 | 16 |
| 31 #content > section | 17 section |
| 32 { | 18 { |
| 33 display: block; | 19 display: inline-block; |
| 34 float: left; | 20 margin: 0 40px 0 0; |
|
saroyanm
2016/02/04 16:03:45
Can't see reason why to use float in this case to
juliandoucette
2016/02/05 13:30:25
Done.
| |
| 35 width: 50%; | 21 } |
| 36 margin-top: 1em; | 22 |
|
saroyanm
2016/02/04 16:03:45
Detail: Please use px to make it consistent with o
juliandoucette
2016/02/05 13:30:25
Done.
| |
| 23 h3 | |
| 24 { | |
| 25 margin: 0px 0 10px 0; | |
| 37 } | 26 } |
| 38 | 27 |
| 39 .contributors-table | 28 .contributors-table |
| 40 { | 29 { |
| 41 width: 90%; | 30 margin: 0 0 40px 0; |
| 42 } | |
| 43 | |
| 44 @media(max-width: 980px) | |
| 45 { | |
| 46 #content > section | |
| 47 { | |
| 48 display: block; | |
|
saroyanm
2016/02/04 16:03:45
This float hack shouldn't be necessary if we will
juliandoucette
2016/02/05 13:30:25
Done.
| |
| 49 float: none; | |
| 50 clear: both; | |
| 51 width: 100%; | |
| 52 } | |
| 53 .contributors-table | |
| 54 { | |
| 55 width: 100%; | |
| 56 } | |
| 57 } | |
| 58 | |
| 59 .contributors-table | |
| 60 { | |
| 61 border: 0; | 31 border: 0; |
| 62 } | 32 } |
| 63 | 33 |
| 64 .contributors-table td | 34 .contributors-table td |
| 65 { | 35 { |
| 66 padding: 10px 5px; | 36 padding: 10px 5px; |
| 37 min-width: 200px; | |
| 67 border: 0; | 38 border: 0; |
|
saroyanm
2016/02/04 16:03:45
Detail: please specify units.
juliandoucette
2016/02/05 13:30:25
Acknowledged.
I just moved this line. I didn't ch
| |
| 68 min-width: 200px; | |
| 69 } | 39 } |
| 70 | 40 |
| 71 .contributors-table thead | 41 .contributors-table thead |
| 72 { | 42 { |
| 73 border-width: 1px; | 43 border-width: 1px; |
| 74 border-color: #7d7d7d; | 44 border-color: #7d7d7d; |
| 75 border-style: dashed none; | 45 border-style: dashed none; |
| 76 } | 46 } |
| 77 | 47 |
| 78 .contributors-table thead td | 48 .contributors-table thead td |
| (...skipping 14 matching lines...) Expand all Loading... | |
| 93 height: 40px; | 63 height: 40px; |
| 94 padding: 10px 0 5px 0; | 64 padding: 10px 0 5px 0; |
| 95 vertical-align: bottom; | 65 vertical-align: bottom; |
| 96 } | 66 } |
| 97 | 67 |
| 98 .contributors-table tbody td | 68 .contributors-table tbody td |
| 99 { | 69 { |
| 100 padding: 5px 5px; | 70 padding: 5px 5px; |
| 101 } | 71 } |
| 102 | 72 |
| 103 @media(max-width: 460px) | 73 @media(max-width: 980px) |
| 104 { | 74 { |
| 105 .contributors-table td | 75 #content |
| 106 { | 76 { |
| 107 font-size: 12px; | 77 width: auto; |
| 108 min-width: 140px; | 78 } |
| 109 } | 79 |
| 110 } | 80 section |
| 111 | 81 { |
| 112 .contributors-table | 82 display: block; |
| 83 margin: 0px; | |
| 84 } | |
| 85 | |
| 86 .contributors-table | |
| 87 { | |
| 88 width: 100%; | |
| 89 } | |
| 90 | |
| 91 .contributors-table td | |
| 92 { | |
| 93 min-width: inherit; | |
| 94 width: 50%; | |
| 95 } | |
| 96 } | |
| 97 | |
| 113 </style> | 98 </style> |
| 114 </head> | 99 </head> |
| 115 <section id="team"> | 100 <section id="team"> |
| 116 <h3>{{s1 Team}}</h3> | 101 <h3>{{s1 Team}}</h3> |
| 117 <table class="contributors-table" rules="groups"> | 102 <table class="contributors-table" rules="groups"> |
| 118 <thead> | 103 <thead> |
| 119 <tr> | 104 <tr> |
| 120 <td>{{s2 Name}}</td> | 105 <td>{{s2 Name}}</td> |
| 121 <td>{{s3 Role}}</td> | 106 <td>{{s3 Role}}</td> |
| 122 </tr> | 107 </tr> |
| (...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 290 <td>Nickolay Ponomarev</td> | 275 <td>Nickolay Ponomarev</td> |
| 291 <td>{{s44 Developer (performance)}}</td> | 276 <td>{{s44 Developer (performance)}}</td> |
| 292 </tr> | 277 </tr> |
| 293 <tr> | 278 <tr> |
| 294 <td>Sebastian Schmidt (yath)</td> | 279 <td>Sebastian Schmidt (yath)</td> |
| 295 <td>{{s45 Developer (Adblock Plus for Android bug fix)}}</td> | 280 <td>{{s45 Developer (Adblock Plus for Android bug fix)}}</td> |
| 296 </tr> | 281 </tr> |
| 297 </tbody> | 282 </tbody> |
| 298 </table> | 283 </table> |
| 299 </section> | 284 </section> |
| LEFT | RIGHT |
« no previous file
|
no next file »
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
