Issue 29335396: Issue 154 - Make the devtools panel generate domain specific filters when $genericblock is active

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29335396: Issue 154 - Make the devtools panel generate domain specific filters when $genericblock is active (Closed)

Created:
Feb. 3, 2016, 9:57 a.m. by Sebastian Noack

Modified:
Feb. 3, 2016, 10:40 a.m.

Reviewers:
Thomas Greiner, kzar

Visibility:
Public.

Description

Issue 154 - Make the devtools panel generate domain specific filters when $genericblock is active

Patch Set 1 #

Total comments: 3

Created: Feb. 3, 2016, 9:57 a.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -6 lines)			Patch
	M	devtools-panel.js	View		2 chunks	+19 lines, -6 lines	3 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

kzar

Otherwise LGTM https://codereview.adblockplus.org/29335396/diff/29335397/devtools-panel.js File devtools-panel.js (right): https://codereview.adblockplus.org/29335396/diff/29335397/devtools-panel.js#newcode30 devtools-panel.js:30: domainSpecific = true; Nit: `domainSpecific = domainSpecific ...

Feb. 3, 2016, 10:27 a.m. (2016-02-03 10:27:17 UTC) #2

Sebastian Noack

https://codereview.adblockplus.org/29335396/diff/29335397/devtools-panel.js File devtools-panel.js (right): https://codereview.adblockplus.org/29335396/diff/29335397/devtools-panel.js#newcode30 devtools-panel.js:30: domainSpecific = true; On 2016/02/03 10:27:17, kzar wrote: > ...

Feb. 3, 2016, 10:35 a.m. (2016-02-03 10:35:27 UTC) #4

kzar

Feb. 3, 2016, 10:40 a.m. (2016-02-03 10:40:27 UTC) #5

Message was sent while issue was closed.

https://codereview.adblockplus.org/29335396/diff/29335397/devtools-panel.js
File devtools-panel.js (right):

https://codereview.adblockplus.org/29335396/diff/29335397/devtools-panel.js#n...
devtools-panel.js:30: domainSpecific = true;
On 2016/02/03 10:35:27, Sebastian Noack wrote:
> On 2016/02/03 10:27:17, kzar wrote:
> > Nit: `domainSpecific = domainSpecific || request.url == "about:blank";`? (Or
> > just check for `if (domainSpecific || request.url == "about:blank")` later?)
> 
> No, that's only if it's a popup.

Acknowledged. Though the first suggestion still stands. Doesn't matter too much
either way anyway.

Expand All Messages | Collapse All Messages