Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29335457: Issue 3618 - Add a script for generating the JSDoc documentation (Closed)

Created:
Feb. 3, 2016, 10:52 a.m. by Felix Dahlke
Modified:
Feb. 5, 2016, 5:09 p.m.
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

Issue 3618 - Add a script for generating the JSDoc documentation

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed import order (alphabetical) #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+399 lines, -0 lines) Patch
A dependencies View 1 chunk +3 lines, -0 lines 0 comments Download
A ensure_dependencies.py View 1 chunk +371 lines, -0 lines 0 comments Download
A generate_docs.py View 1 1 chunk +25 lines, -0 lines 2 comments Download

Messages

Total messages: 4
Felix Dahlke
https://codereview.adblockplus.org/29335457/diff/29335458/generate_docs.py File generate_docs.py (right): https://codereview.adblockplus.org/29335457/diff/29335458/generate_docs.py#newcode18 generate_docs.py:18: # We're faking an invocation of build.py here, because ...
Feb. 3, 2016, 10:59 a.m. (2016-02-03 10:59:55 UTC) #1
Wladimir Palant
https://codereview.adblockplus.org/29335457/diff/29335763/generate_docs.py File generate_docs.py (right): https://codereview.adblockplus.org/29335457/diff/29335763/generate_docs.py#newcode25 generate_docs.py:25: buildtools.build.processArgs(BASE_DIR, args) As hacks go, I think this one ...
Feb. 4, 2016, 10:19 p.m. (2016-02-04 22:19:54 UTC) #2
Felix Dahlke
https://codereview.adblockplus.org/29335457/diff/29335763/generate_docs.py File generate_docs.py (right): https://codereview.adblockplus.org/29335457/diff/29335763/generate_docs.py#newcode25 generate_docs.py:25: buildtools.build.processArgs(BASE_DIR, args) On 2016/02/04 22:19:54, Wladimir Palant wrote: > ...
Feb. 5, 2016, 6:17 a.m. (2016-02-05 06:17:54 UTC) #3
Wladimir Palant
Feb. 5, 2016, 12:30 p.m. (2016-02-05 12:30:39 UTC) #4
Well, LGTM I guess...

Powered by Google App Engine
This is Rietveld