Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(365)

Issue 29335462: Issue 3337 - Update adblockplus reference in libadblockplus to revision hg:813682c7161e (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years ago by sergei
Modified:
3 years, 10 months ago
Reviewers:
Oleksandr
CC:
Felix Dahlke, Eric, René Jeschke
Visibility:
Public.

Description

Changes in the code are mainly introduced by #2738. Make added JavaScript file 'cssRules.js' to be processed by `convert_js`. Note about type for content type mask (signed 32 bit integer, int32_t): it's not unsigned and its size is 32 bit because of peculiarities of bitmasks in JavaScipt https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Operators/Bitwise_Operators.

Patch Set 1 #

Total comments: 4

Patch Set 2 : add typedef for ContentTypeMask #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -82 lines) Patch
M dependencies View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ensure_dependencies.py View 10 chunks +83 lines, -53 lines 0 comments Download
M include/AdblockPlus/FilterEngine.h View 1 2 6 chunks +33 lines, -13 lines 0 comments Download
M lib/api.js View 1 chunk +2 lines, -2 lines 0 comments Download
M libadblockplus.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M src/FilterEngine.cpp View 1 7 chunks +15 lines, -13 lines 0 comments Download
M test/FilterEngine.cpp View 1 chunk +62 lines, -0 lines 0 comments Download

Messages

Total messages: 6
sergei
4 years ago (2016-02-03 13:34:33 UTC) #1
Oleksandr
LGTM
4 years ago (2016-02-04 04:14:11 UTC) #2
Eric
https://codereview.adblockplus.org/29335462/diff/29335463/include/AdblockPlus/FilterEngine.h File include/AdblockPlus/FilterEngine.h (right): https://codereview.adblockplus.org/29335462/diff/29335463/include/AdblockPlus/FilterEngine.h#newcode294 include/AdblockPlus/FilterEngine.h:294: int32_t contentTypeMask, It would seem better to use uint32_t ...
4 years ago (2016-02-09 15:43:04 UTC) #3
sergei
https://codereview.adblockplus.org/29335462/diff/29335463/include/AdblockPlus/FilterEngine.h File include/AdblockPlus/FilterEngine.h (right): https://codereview.adblockplus.org/29335462/diff/29335463/include/AdblockPlus/FilterEngine.h#newcode294 include/AdblockPlus/FilterEngine.h:294: int32_t contentTypeMask, On 2016/02/09 15:43:03, Eric wrote: > It ...
4 years ago (2016-02-09 17:15:47 UTC) #4
sergei
René or Eric, could you please review it?
4 years ago (2016-02-18 10:34:47 UTC) #5
sergei
3 years, 10 months ago (2016-04-19 17:44:04 UTC) #6
FYI: I'm going to push this changes tomorrow.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5