Issue 29335650: Issue 2595 - Use the core code from adblockpluscore

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29335650: Issue 2595 - Use the core code from adblockpluscore (Closed)

Created:
Feb. 4, 2016, 6:35 p.m. by Felix Dahlke

Modified:
Feb. 4, 2016, 8:13 p.m.

Reviewers:
Wladimir Palant

Visibility:
Public.

Description

Issue 2595 - Use the core code from adblockpluscore

Patch Set 1 #

Created: Feb. 4, 2016, 6:35 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -5127 lines)			Patch
R	chrome/content/cssProperties.js	View	1 chunk	+0 lines, -87 lines	0 comments	Download
R	chrome/content/ui/subscriptions.xml	View	1 chunk	+0 lines, -126 lines	0 comments	Download
M	dependencies	View	1 chunk	+1 line, -0 lines	0 comments	Download
R	lib/antiadblockInit.js	View	1 chunk	+0 lines, -85 lines	0 comments	Download
R	lib/cssRules.js	View	1 chunk	+0 lines, -76 lines	0 comments	Download
R	lib/downloader.js	View	1 chunk	+0 lines, -394 lines	0 comments	Download
R	lib/elemHide.js	View	1 chunk	+0 lines, -389 lines	0 comments	Download
R	lib/filterClasses.js	View	1 chunk	+0 lines, -1070 lines	0 comments	Download
R	lib/filterListener.js	View	1 chunk	+0 lines, -290 lines	0 comments	Download
R	lib/filterNotifier.js	View	1 chunk	+0 lines, -73 lines	0 comments	Download
R	lib/filterStorage.js	View	1 chunk	+0 lines, -800 lines	0 comments	Download
R	lib/matcher.js	View	1 chunk	+0 lines, -407 lines	0 comments	Download
R	lib/notification.js	View	1 chunk	+0 lines, -412 lines	0 comments	Download
R	lib/subscriptionClasses.js	View	1 chunk	+0 lines, -597 lines	0 comments	Download
R	lib/synchronizer.js	View	1 chunk	+0 lines, -320 lines	0 comments	Download
M	metadata.gecko	View	2 chunks	+15 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Felix Dahlke

Note that I won't land this before https://issues.adblockplus.org/ticket/1299, https://issues.adblockplus.org/ticket/3618 and https://issues.adblockplus.org/ticket/3621, otherwise we'd lose the ...

Feb. 4, 2016, 6:40 p.m. (2016-02-04 18:40:01 UTC) #2

LGTM

Expand All Messages | Collapse All Messages