 Issue 29336084:
  Issue 2426 - Open block.html as a popup window  (Closed)
    
  
    Issue 29336084:
  Issue 2426 - Open block.html as a popup window  (Closed) 
  | Index: safari/ext/background.js | 
| diff --git a/safari/ext/background.js b/safari/ext/background.js | 
| index 2c3d5ec9aa8fd4b992efd1e8d38e493cc21b2ca5..706a76b684d3bf7cb8d007cd288751dba107b0ca 100644 | 
| --- a/safari/ext/background.js | 
| +++ b/safari/ext/background.js | 
| @@ -222,6 +222,8 @@ | 
| var forgetPage = function(id) | 
| { | 
| + ext.pages.onRemoved._dispatch(id); | 
| + | 
| ext._removeFromAllPageMaps(id); | 
| delete pages[id]._tab._pages[id]; | 
| @@ -305,6 +307,7 @@ | 
| }, | 
| onLoading: new ext._EventTarget(), | 
| onActivated: new ext._EventTarget(), | 
| + onRemoved: new ext._EventTarget() | 
| }; | 
| safari.application.addEventListener("close", function(event) | 
| @@ -754,4 +757,15 @@ | 
| ext.pages.open(optionsUrl, callback); | 
| }; | 
| + | 
| + /* Windows */ | 
| + ext.windows = { | 
| + // Safari doesn't provide as rich a windows API as Chrome does, so instead | 
| + // of chrome.windows.create we have to fall back to just opening a new tab. | 
| + create: function(createData, callback) | 
| + { | 
| + if (createData && createData.url) | 
| 
Sebastian Noack
2016/02/10 12:26:57
Just assume the URL to be given? If it's missing,
 
kzar
2016/02/10 14:20:17
Done.
 | 
| + ext.pages.open(createData.url, callback); | 
| + } | 
| + }; | 
| })(); |