Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29336255: Issue 3649 - Truncate notificationDownloadCount (Closed)

Created:
Feb. 11, 2016, 2:24 p.m. by kzar
Modified:
Feb. 22, 2016, 3:43 p.m.
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 3649 - Truncate notificationDownloadCount

Patch Set 1 #

Total comments: 6

Patch Set 2 : Addressed Sebastian's feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M lib/uninstall.js View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4
kzar
Feb. 11, 2016, 2:25 p.m. (2016-02-11 14:25:40 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29336255/diff/29336256/lib/uninstall.js File lib/uninstall.js (right): https://codereview.adblockplus.org/29336255/diff/29336256/lib/uninstall.js#newcode33 lib/uninstall.js:33: if (typeof(downlCount) == "number" && downlCount > 3) Nit: ...
Feb. 11, 2016, 2:31 p.m. (2016-02-11 14:31:24 UTC) #2
kzar
Patch Set 2 : Addressed Sebastian's feedback https://codereview.adblockplus.org/29336255/diff/29336256/lib/uninstall.js File lib/uninstall.js (right): https://codereview.adblockplus.org/29336255/diff/29336256/lib/uninstall.js#newcode33 lib/uninstall.js:33: if (typeof(downlCount) ...
Feb. 11, 2016, 2:45 p.m. (2016-02-11 14:45:20 UTC) #3
Sebastian Noack
Feb. 11, 2016, 2:55 p.m. (2016-02-11 14:55:24 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld