Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29336327: Issue 2834 - Enable translations for adblockplusui (Closed)

Created:
Feb. 13, 2016, 1:45 p.m. by kzar
Modified:
Feb. 15, 2016, 5:13 p.m.
Reviewers:
Thomas Greiner
CC:
Sebastian Noack
Visibility:
Public.

Description

Issue 2834 - Enable translations for adblockplusui

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add link to Crowdin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+410 lines, -0 lines) Patch
M README.md View 1 2 chunks +11 lines, -0 lines 0 comments Download
A build.py View 1 chunk +16 lines, -0 lines 0 comments Download
A dependencies View 1 chunk +3 lines, -0 lines 0 comments Download
A ensure_dependencies.py View 1 chunk +371 lines, -0 lines 0 comments Download
A metadata.generic View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3
kzar
Patch Set 1 (Haven't updated the issue yet as the issue tracker is down currently.)
Feb. 13, 2016, 1:47 p.m. (2016-02-13 13:47:57 UTC) #1
Thomas Greiner
LGTM https://codereview.adblockplus.org/29336327/diff/29336328/README.md File README.md (right): https://codereview.adblockplus.org/29336327/diff/29336328/README.md#newcode51 README.md:51: Crowdin platform. To synchronise with Crowdin you can ...
Feb. 15, 2016, 4:25 p.m. (2016-02-15 16:25:45 UTC) #2
kzar
Feb. 15, 2016, 4:50 p.m. (2016-02-15 16:50:55 UTC) #3
Patch Set 2 : Add link to Crowdin

https://codereview.adblockplus.org/29336327/diff/29336328/README.md
File README.md (right):

https://codereview.adblockplus.org/29336327/diff/29336328/README.md#newcode51
README.md:51: Crowdin platform. To synchronise with Crowdin you can use the
build script.
On 2016/02/15 16:25:45, Thomas Greiner wrote:
> Detail: Would be nice to hyperlink the first occurence of "Crowdin" for people
> who don't know it yet.

Done.

Powered by Google App Engine
This is Rietveld