Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29336430: Issue 3659 - Remove locale dependency from filter classes (Closed)

Created:
Feb. 16, 2016, 11:45 a.m. by Wladimir Palant
Modified:
Feb. 17, 2016, 4:36 p.m.
Reviewers:
Thomas Greiner
CC:
Erik
Visibility:
Public.

Description

I migrated the required unit tests from adblockplustests repository. The test itself is unchanged except for the logic around invalid filters, reason being tested explicitly now.

Patch Set 1 #

Patch Set 2 : Added missing license header #

Total comments: 4

Patch Set 3 : Simplified test setup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+382 lines, -6 lines) Patch
A .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
A .hgignore View 1 chunk +1 line, -0 lines 0 comments Download
M README.md View 1 chunk +13 lines, -0 lines 0 comments Download
M lib/filterClasses.js View 3 chunks +5 lines, -6 lines 0 comments Download
A package.json View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
A test/filterClasses.js View 1 1 chunk +345 lines, -0 lines 0 comments Download
A test_wrapper.js View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Wladimir Palant
Feb. 16, 2016, 11:45 a.m. (2016-02-16 11:45:15 UTC) #1
Thomas Greiner
https://codereview.adblockplus.org/29336430/diff/29336483/test_wrapper.js File test_wrapper.js (right): https://codereview.adblockplus.org/29336430/diff/29336483/test_wrapper.js#newcode1 test_wrapper.js:1: #!/usr/bin/env node --harmony Detail: Seems a bit redundant to ...
Feb. 17, 2016, 3:32 p.m. (2016-02-17 15:32:50 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29336430/diff/29336483/test_wrapper.js File test_wrapper.js (right): https://codereview.adblockplus.org/29336430/diff/29336483/test_wrapper.js#newcode1 test_wrapper.js:1: #!/usr/bin/env node --harmony On 2016/02/17 15:32:50, Thomas Greiner wrote: ...
Feb. 17, 2016, 3:53 p.m. (2016-02-17 15:53:02 UTC) #3
Thomas Greiner
Feb. 17, 2016, 4:04 p.m. (2016-02-17 16:04:40 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld