Issue 29337707: No issue - disable signing enforcement to run crawler

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29337707: No issue - disable signing enforcement to run crawler (Closed)

Created:
Feb. 25, 2016, 3:21 p.m. by sergei

Modified:
Feb. 26, 2016, 7:50 p.m.

Reviewers:
Wladimir Palant

Visibility:
Public.

Description

# abpcrawler project Without that parameter crawler extension is not loaded, the output contains the folowing line: 1456410213081 addons.xpi WARN Refusing to install staged add-on abpcrawler@adblockplus.org with signed state 0 More info: https://wiki.mozilla.org/Add-ons/Extension_Signing Review: https://codereview.adblockplus.org/29337707

Patch Set 1 #

Created: Feb. 25, 2016, 3:21 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	run.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Wladimir Palant

Feb. 25, 2016, 5:51 p.m. (2016-02-25 17:51:40 UTC) #2

LGTM

This is only a stopgap solution however, starting with Firefox 46 it won't work
any more. Then we will either have to use pre-release versions of Firefox
(Developer Edition or Nightly) or get the crawler signed (can be done in an
automated fashion but will complicate things significantly).

Expand All Messages | Collapse All Messages