Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29337841: #3075 Added deep-linking to android support faq on adblockbrowser.org (Closed)

Created:
March 1, 2016, 3:24 p.m. by juliandoucette
Modified:
April 20, 2016, 8:40 p.m.
Reviewers:
saroyanm
CC:
Thomas Greiner
Visibility:
Public.

Description

#3075 Added deep-linking to android support faq on adblockbrowser.org

Patch Set 1 : Changed ul to dl and added anchors with id and href to questions #

Total comments: 3

Patch Set 2 : Moved id from `a` to `dt` and dropped `-question` suffix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -16 lines) Patch
M pages/android-support/faq.md View 1 1 chunk +86 lines, -16 lines 0 comments Download

Messages

Total messages: 4
juliandoucette
March 1, 2016, 3:25 p.m. (2016-03-01 15:25:34 UTC) #1
saroyanm
https://codereview.adblockplus.org/29337841/diff/29337842/pages/android-support/faq.md File pages/android-support/faq.md (right): https://codereview.adblockplus.org/29337841/diff/29337842/pages/android-support/faq.md#newcode7 pages/android-support/faq.md:7: margin-bottom: 0.5em; Detail: Please use px. if there is ...
April 8, 2016, 5:51 p.m. (2016-04-08 17:51:44 UTC) #2
juliandoucette
On 2016/04/08 17:51:44, saroyanm wrote: > https://codereview.adblockplus.org/29337841/diff/29337842/pages/android-support/faq.md > File pages/android-support/faq.md (right): > > https://codereview.adblockplus.org/29337841/diff/29337842/pages/android-support/faq.md#newcode7 > ...
April 19, 2016, 6:43 p.m. (2016-04-19 18:43:07 UTC) #3
saroyanm
April 20, 2016, 10:03 a.m. (2016-04-20 10:03:59 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld