Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29337850: Issue 3724 - Add JsValue::Call(const JsValue&) (Closed)

Created:
March 3, 2016, 10:49 a.m. by sergei
Modified:
March 11, 2016, 1:59 p.m.
Reviewers:
Oleksandr
CC:
Felix Dahlke, Eric, René Jeschke
Visibility:
Public.

Description

The current change also affects `Notification` implementation because it has been done mainly for `Notification::GetTexts`.

Patch Set 1 #

Patch Set 2 : typo fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -8 lines) Patch
M include/AdblockPlus/JsValue.h View 1 chunk +8 lines, -0 lines 0 comments Download
M include/AdblockPlus/Notification.h View 1 chunk +1 line, -1 line 0 comments Download
M src/JsValue.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M src/Notification.cpp View 2 chunks +3 lines, -7 lines 0 comments Download
M test/JsValue.cpp View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2
sergei
March 3, 2016, 10:53 a.m. (2016-03-03 10:53:14 UTC) #1
Oleksandr
March 11, 2016, 11:57 a.m. (2016-03-11 11:57:30 UTC) #2
LGTM. Sorry for the delay.

Powered by Google App Engine
This is Rietveld