Issue 3729 - Make "Block element" dialog adapt to variable window sizes

Issue 3729 - Make "Block element" dialog adapt to variable window sizes

[saroyanm, 2016-03-03 15:29:25]

https://codereview.adblockplus.org/29337873/diff/29337874/block.html
File block.html (right):

https://codereview.adblockplus.org/29337873/diff/29337874/block.html#newcode42
block.html:42: font-family: Arial, Helvetica, sans-serif;
Detail: Can you please reorder css properties with the order specified in the
https://adblockplus.org/en/coding-style

https://codereview.adblockplus.org/29337873/diff/29337874/block.html#newcode73
block.html:73: height: 100px;
while we are using the grow factor I think we can leave height specification to
the browser.

[Sebastian Noack, 2016-03-03 15:40:14]

https://codereview.adblockplus.org/29337873/diff/29337874/block.html
File block.html (right):

https://codereview.adblockplus.org/29337873/diff/29337874/block.html#newcode42
block.html:42: font-family: Arial, Helvetica, sans-serif;
On 2016/03/03 15:29:25, saroyanm wrote:
> Detail: Can you please reorder css properties with the order specified in the
> https://adblockplus.org/en/coding-style 

Done, I think.

https://codereview.adblockplus.org/29337873/diff/29337874/block.html#newcode73
block.html:73: height: 100px;
On 2016/03/03 15:29:25, saroyanm wrote:
> while we are using the grow factor I think we can leave height specification
to
> the browser.

Yes, for modern browsers, the height doesn't have any effect as this element has
flex-growth and flex-shrink of 1, while all other elements in this flex
container have flex-growth and flex-shrink of 0. I left it in merely for Safari
<=6.0 which doesn't support flexbox. But it's probably fine to just fallback to
the default textarea height there.

[saroyanm, 2016-03-03 16:11:34]

LGTM

https://codereview.adblockplus.org/29337873/diff/29337874/block.html
File block.html (right):

https://codereview.adblockplus.org/29337873/diff/29337874/block.html#newcode42
block.html:42: font-family: Arial, Helvetica, sans-serif;
On 2016/03/03 15:40:14, Sebastian Noack wrote:
> On 2016/03/03 15:29:25, saroyanm wrote:
> > Detail: Can you please reorder css properties with the order specified in
the
> > https://adblockplus.org/en/coding-style 
> 
> Done, I think.

Yes only one small note: please move display properties on top.

[Sebastian Noack, 2016-03-03 17:42:33]

https://codereview.adblockplus.org/29337873/diff/29337874/block.html
File block.html (right):

https://codereview.adblockplus.org/29337873/diff/29337874/block.html#newcode42
block.html:42: font-family: Arial, Helvetica, sans-serif;
On 2016/03/03 16:11:34, saroyanm wrote:
> On 2016/03/03 15:40:14, Sebastian Noack wrote:
> > On 2016/03/03 15:29:25, saroyanm wrote:
> > > Detail: Can you please reorder css properties with the order specified in
> the
> > > https://adblockplus.org/en/coding-style 
> > 
> > Done, I think.
> 
> Yes only one small note: please move display properties on top.

I did leave the display property definition below as it is flex-box related,
which I think is also kinda inline with that WordPress article which states to
group similar properties.