Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: block.html

Issue 29337873: Issue 3729 - Make "Block element" dialog adapt to variable window sizes (Closed)
Patch Set: Created March 3, 2016, 2:13 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: block.html
===================================================================
--- a/block.html
+++ b/block.html
@@ -29,13 +29,25 @@
<script type="text/javascript" src="i18n.js" charset="utf-8"></script>
<script type="text/javascript" src="block.js" charset="utf-8"></script>
<style type="text/css">
+ *
+ {
+ box-sizing: border-box;
+ }
+ html
+ {
+ height: 100%;
+ }
body
{
font-family: Arial, Helvetica, sans-serif;
saroyanm 2016/03/03 15:29:25 Detail: Can you please reorder css properties with
Sebastian Noack 2016/03/03 15:40:14 Done, I think.
saroyanm 2016/03/03 16:11:34 Yes only one small note: please move display prope
Sebastian Noack 2016/03/03 17:42:32 I did leave the display property definition below
font-size: 13px;
margin: 0px;
padding: 5px;
- display: inline-block;
+ height: 100%;
+ display: -webkit-flex;
+ display: flex;
+ -webkit-flex-direction: column;
+ flex-direction: column;
}
#title,
#filters
@@ -50,13 +62,20 @@
{
margin-right: 5px;
}
+ #title, #buttons
+ {
+ -webkit-flex-shrink: 0;
+ flex-shrink: 0;
+ }
#filters
{
- width: 400px;
+ width: 100%;
height: 100px;
saroyanm 2016/03/03 15:29:25 while we are using the grow factor I think we can
Sebastian Noack 2016/03/03 15:40:14 Yes, for modern browsers, the height doesn't have
resize: none;
white-space: pre;
word-wrap: normal;
+ -webkit-flex-grow: 1;
+ flex-grow: 1;
}
#buttons
{
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld