Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29337957: Issue 3759 - Removed PAD generation code (Closed)

Created:
March 8, 2016, 4:31 p.m. by Sebastian Noack
Modified:
March 8, 2016, 5:43 p.m.
Reviewers:
kzar, Wladimir Palant
Visibility:
Public.

Description

Issue 3759 - Removed PAD generation code

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1024 lines) Patch
M .sitescripts.example View 5 chunks +0 lines, -9 lines 0 comments Download
R sitescripts/extensions/android.py View 1 chunk +0 lines, -31 lines 0 comments Download
R sitescripts/extensions/bin/updateDownloadLinks.py View 1 chunk +0 lines, -52 lines 1 comment Download
R sitescripts/extensions/pad/__init__.py View 1 chunk +0 lines, -187 lines 0 comments Download
R sitescripts/extensions/pad/language.py View 1 chunk +0 lines, -178 lines 0 comments Download
R sitescripts/extensions/pad/validation.py View 1 chunk +0 lines, -209 lines 0 comments Download
R sitescripts/extensions/template/pad.xml View 1 chunk +0 lines, -343 lines 0 comments Download
M sitescripts/extensions/utils.py View 4 chunks +7 lines, -15 lines 3 comments Download

Messages

Total messages: 5
Sebastian Noack
https://codereview.adblockplus.org/29337957/diff/29337958/sitescripts/extensions/bin/updateDownloadLinks.py File sitescripts/extensions/bin/updateDownloadLinks.py (left): https://codereview.adblockplus.org/29337957/diff/29337958/sitescripts/extensions/bin/updateDownloadLinks.py#oldcode44 sitescripts/extensions/bin/updateDownloadLinks.py:44: getDownloadLinks(result) This logic is dead code as well, since ...
March 8, 2016, 4:34 p.m. (2016-03-08 16:34:16 UTC) #1
kzar
LGTM
March 8, 2016, 4:39 p.m. (2016-03-08 16:39:26 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29337957/diff/29337958/sitescripts/extensions/utils.py File sitescripts/extensions/utils.py (left): https://codereview.adblockplus.org/29337957/diff/29337958/sitescripts/extensions/utils.py#oldcode217 sitescripts/extensions/utils.py:217: def basename(self): If I see it correctly, this property ...
March 8, 2016, 4:58 p.m. (2016-03-08 16:58:15 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29337957/diff/29337958/sitescripts/extensions/utils.py File sitescripts/extensions/utils.py (left): https://codereview.adblockplus.org/29337957/diff/29337958/sitescripts/extensions/utils.py#oldcode217 sitescripts/extensions/utils.py:217: def basename(self): On 2016/03/08 16:58:14, Wladimir Palant wrote: > ...
March 8, 2016, 5:01 p.m. (2016-03-08 17:01:02 UTC) #4
Wladimir Palant
March 8, 2016, 5:34 p.m. (2016-03-08 17:34:12 UTC) #5 
LGTM

https://codereview.adblockplus.org/29337957/diff/29337958/sitescripts/extensi...
File sitescripts/extensions/utils.py (left):

https://codereview.adblockplus.org/29337957/diff/29337958/sitescripts/extensi...
sitescripts/extensions/utils.py:217: def basename(self):
On 2016/03/08 17:01:02, Sebastian Noack wrote:
> If I see it correctly, we introduced that property when we added the PAD
> generation code, and I couldn't find any other usage of it. I might be wrong
> though, but are you sure that you didn't confuse it with os.path.basename?

I didn't but there appears to be a separate NightlyBuild.basename property. Fine
with me then.

Powered by Google App Engine
This is Rietveld