Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29338061: Noissue - Create a wrapper around upload.py with a more convenient command line interface (Closed)

Created:
March 10, 2016, 12:07 p.m. by Wladimir Palant
Modified:
March 10, 2016, 12:49 p.m.
Reviewers:
Sebastian Noack
CC:
Felix Dahlke
Visibility:
Public.

Description

This review has been created by running hg review command. Differences to upload.py: 1) Mercurial`s global command line parameters -q/-v/--debug are supported. 2) Consistent revision parameters: -r/-c like with hg diff (short form of --reviewers had to be changed into -w). 3) Adds @adblockplus.org to email addresses automatically if missing. 4) Mails sent automatically (always when a new review is created and only if -m present for updates). 5) Title set automatically for new reviews if -c is specified. 6) Setting reviewers mandatory for new reviews, also revision/revision range always has to be specified explicitly.

Patch Set 1 #

Total comments: 5

Patch Set 2 : Addressed nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -0 lines) Patch
A .hgignore View 1 chunk +1 line, -0 lines 0 comments Download
M hgrc View 1 chunk +5 lines, -0 lines 0 comments Download
A hgreview.py View 1 1 chunk +80 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Wladimir Palant
March 10, 2016, 12:07 p.m. (2016-03-10 12:07:08 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29338061/diff/29338062/hgreview.py File hgreview.py (right): https://codereview.adblockplus.org/29338061/diff/29338062/hgreview.py#newcode12 hgreview.py:12: @command('review', Note that cmdutil isn't a standard library. IMO ...
March 10, 2016, 12:31 p.m. (2016-03-10 12:31:05 UTC) #2
Wladimir Palant
March 10, 2016, 12:36 p.m. (2016-03-10 12:36:20 UTC) #3
Wladimir Palant
https://codereview.adblockplus.org/29338061/diff/29338062/hgreview.py File hgreview.py (right): https://codereview.adblockplus.org/29338061/diff/29338062/hgreview.py#newcode12 hgreview.py:12: @command('review', On 2016/03/10 12:31:05, Sebastian Noack wrote: > Note ...
March 10, 2016, 12:36 p.m. (2016-03-10 12:36:37 UTC) #4
Sebastian Noack
March 10, 2016, 12:44 p.m. (2016-03-10 12:44:28 UTC) #5
LGTM

https://codereview.adblockplus.org/29338061/diff/29338062/hgreview.py
File hgreview.py (right):

https://codereview.adblockplus.org/29338061/diff/29338062/hgreview.py#newcode12
hgreview.py:12: @command('review',
On 2016/03/10 12:36:36, Wladimir Palant wrote:
> On 2016/03/10 12:31:05, Sebastian Noack wrote:
> > Note that cmdutil isn't a standard library.
> 
> No, it isn't a standard library but it is documented Mercurial API and
> recommended for Mercurial extensions. I think that by reimplementing we would
> create a larger risk of incompatibilities than by sticking with it.

I just realized that this is a Mercurial extension, and that this module comes
from Mercurial's API. So it actually makes sense to use it here.

Powered by Google App Engine
This is Rietveld