Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(115)

Issue 29338107: Issue 3771 - Update adblockpluscore dependency and adapt filter validation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 11 months ago by Sebastian Noack
Modified:
3 years, 11 months ago
Reviewers:
kzar
CC:
Wladimir Palant
Visibility:
Public.

Description

Issue 3771 - Update adblockpluscore dependency and adapt filter validation

Patch Set 1 #

Patch Set 2 : Updated adblockplus dependecy and import new strings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M dependencies View 1 1 chunk +2 lines, -2 lines 0 comments Download
M lib/filterValidation.js View 2 chunks +9 lines, -4 lines 0 comments Download
M metadata.common View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7
Sebastian Noack
3 years, 11 months ago (2016-03-10 14:55:21 UTC) #1
kzar
Don't we also need to add the strings for these error messages? For example where ...
3 years, 11 months ago (2016-03-10 16:17:31 UTC) #2
Sebastian Noack
On 2016/03/10 16:17:31, kzar wrote: > Don't we also need to add the strings for ...
3 years, 11 months ago (2016-03-10 16:19:29 UTC) #3
Sebastian Noack
Since the strings landed now in adblockplus, I updated this review to import the related ...
3 years, 11 months ago (2016-03-11 15:36:29 UTC) #4
kzar
LGTM (I don't want to argue about it, much less on your birthday, but I ...
3 years, 11 months ago (2016-03-11 15:43:09 UTC) #5
Sebastian Noack
On 2016/03/11 15:43:09, kzar wrote: > (I don't want to argue about it, much less ...
3 years, 11 months ago (2016-03-11 16:04:15 UTC) #6
kzar
3 years, 11 months ago (2016-03-11 17:28:48 UTC) #7
Message was sent while issue was closed.
On 2016/03/11 16:04:15, Sebastian Noack wrote: 
> I will figure out what needs to be done to move the strings to adblockplusui.
> But for the time being I prefer to have the shared strings in one place.
> Besides, there might be more to be done in order to reuse those strings in
> Adblock Plus for Firefox.

OK, fair enough.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5