Noissue - Added missing strings for invalid filters

Noissue - Added missing strings for invalid filters

[kzar, 2016-03-10 16:23:37]

Shouldn't these strings live in adblockplusui rather than adblockplus? Otherwise
we continue to require adblockplus as a dependency for adblockpluschrome.

[Sebastian Noack, 2016-03-10 16:28:25]

On 2016/03/10 16:23:37, kzar wrote:
> Shouldn't these strings live in adblockplusui rather than adblockplus?
Otherwise
> we continue to require adblockplus as a dependency for adblockpluschrome.

Yes, we currently still depend on adblockplus. Getting rid of that dependency is
a separate issue.

[kzar, 2016-03-10 16:31:57]

On 2016/03/10 16:28:25, Sebastian Noack wrote:
> Getting rid of that dependency is a separate issue.

It's a separate issue but surely we shouldn't be working against it here?

[Sebastian Noack, 2016-03-10 16:34:23]

On 2016/03/10 16:31:57, kzar wrote:
> On 2016/03/10 16:28:25, Sebastian Noack wrote:
> > Getting rid of that dependency is a separate issue.
> 
> It's a separate issue but surely we shouldn't be working against it here?

Surely, we shouldn't block ourselves from updating the adblockpluscore
dependency because that silly issue. It was bad enough that we had to skip it
for the 1.11 release, and cannot skip it again next time. Not that the changes
here make anything worse as it already is.

[Thomas Greiner, 2016-03-10 16:36:05]

LGTM

[kzar, 2016-03-10 16:36:29]

On 2016/03/10 16:34:23, Sebastian Noack wrote:
> Surely, we shouldn't block ourselves from updating the adblockpluscore
> dependency because that silly issue. It was bad enough that we had to skip it
> for the 1.11 release, and cannot skip it again next time. Not that the changes
> here make anything worse as it already is.

I guess I misunderstand why this is blocking us as well. If we added these
strings to adblockplusui instead we could also update the adblockpluscore
dependency.

[Sebastian Noack, 2016-03-10 16:43:52]

On 2016/03/10 16:36:29, kzar wrote:
> On 2016/03/10 16:34:23, Sebastian Noack wrote:
> > Surely, we shouldn't block ourselves from updating the adblockpluscore
> > dependency because that silly issue. It was bad enough that we had to skip
it
> > for the 1.11 release, and cannot skip it again next time. Not that the
changes
> > here make anything worse as it already is.
> 
> I guess I misunderstand why this is blocking us as well. If we added these
> strings to adblockplusui instead we could also update the adblockpluscore
> dependency.

These strings are currently missing in both Adblock Plus for Chrome and Firefox.
Hence the UI will show an empty string as soon as the adblockpluscore dependecy
has been updated. However, IIRC, there is more than simply moving the strings to
adblockplusui that prevents us from doing so. Feel free to look into that.