Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29338118: Issue 3772 - Bring back anti-adblock warning removal subscription (Closed)

Created:
March 10, 2016, 3:49 p.m. by Sebastian Noack
Modified:
March 11, 2016, 4 p.m.
Reviewers:
kzar
Visibility:
Public.

Description

Issue 3772 - Bring back anti-adblock warning removal subscription

Patch Set 1 #

Total comments: 2

Patch Set 2 : Wrapped long lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M background.js View 1 1 chunk +16 lines, -1 line 0 comments Download

Messages

Total messages: 4
Sebastian Noack
March 10, 2016, 3:50 p.m. (2016-03-10 15:50:19 UTC) #1
kzar
https://codereview.adblockplus.org/29338118/diff/29338119/background.js File background.js (right): https://codereview.adblockplus.org/29338118/diff/29338119/background.js#newcode203 background.js:203: if (subscription instanceof DownloadableSubscription && !subscription.lastDownload) Nit: Mind wrapping ...
March 10, 2016, 4:20 p.m. (2016-03-10 16:20:25 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29338118/diff/29338119/background.js File background.js (right): https://codereview.adblockplus.org/29338118/diff/29338119/background.js#newcode203 background.js:203: if (subscription instanceof DownloadableSubscription && !subscription.lastDownload) On 2016/03/10 16:20:24, ...
March 11, 2016, 3:41 p.m. (2016-03-11 15:41:01 UTC) #3
kzar
March 11, 2016, 3:49 p.m. (2016-03-11 15:49:56 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld