Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1283)

Issue 29338153: Issue 3780 - wait for the loading of filters and only afterwards start to fetch pages (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 4 months ago by sergei
Modified:
3 years, 4 months ago
Reviewers:
Wladimir Palant
Visibility:
Public.

Description

# abpcrawler project The code also assumes that after loading of filters there is at least one subscription.

Patch Set 1 #

Total comments: 16

Patch Set 2 : address comments #

Total comments: 6

Patch Set 3 : move .catch() on the same line with .then() #

Patch Set 4 : make crawl_urls function #

Patch Set 5 : remove empty line #

Patch Set 6 : don't use internal FilterStorage._loading #

Total comments: 4

Patch Set 7 : remove onFiltersLoaded listener and fit 80 chars #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -3 lines) Patch
M lib/crawler.js View 1 2 3 4 5 6 3 chunks +46 lines, -3 lines 0 comments Download

Messages

Total messages: 9
sergei
3 years, 4 months ago (2016-03-11 16:02:18 UTC) #1
Wladimir Palant
https://codereview.adblockplus.org/29338153/diff/29338154/lib/crawler.js File lib/crawler.js (right): https://codereview.adblockplus.org/29338153/diff/29338154/lib/crawler.js#newcode224 lib/crawler.js:224: new Promise(function(resolve, reject) Nit: Why not use arrow functions ...
3 years, 4 months ago (2016-03-15 09:13:11 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29338153/diff/29338154/lib/crawler.js File lib/crawler.js (right): https://codereview.adblockplus.org/29338153/diff/29338154/lib/crawler.js#newcode226 lib/crawler.js:226: if (FilterStorage.subscriptions.length > 0 && !FilterStorage._loading) On 2016/03/15 09:13:10, ...
3 years, 4 months ago (2016-03-15 09:18:12 UTC) #3
sergei
https://codereview.adblockplus.org/29338153/diff/29338154/lib/crawler.js File lib/crawler.js (right): https://codereview.adblockplus.org/29338153/diff/29338154/lib/crawler.js#newcode224 lib/crawler.js:224: new Promise(function(resolve, reject) On 2016/03/15 09:13:10, Wladimir Palant wrote: ...
3 years, 4 months ago (2016-03-15 12:16:24 UTC) #4
Wladimir Palant
https://codereview.adblockplus.org/29338153/diff/29338154/lib/crawler.js File lib/crawler.js (right): https://codereview.adblockplus.org/29338153/diff/29338154/lib/crawler.js#newcode224 lib/crawler.js:224: new Promise(function(resolve, reject) On 2016/03/15 12:16:23, sergei wrote: > ...
3 years, 4 months ago (2016-03-15 13:44:22 UTC) #5
sergei
https://codereview.adblockplus.org/29338153/diff/29338154/lib/crawler.js File lib/crawler.js (right): https://codereview.adblockplus.org/29338153/diff/29338154/lib/crawler.js#newcode226 lib/crawler.js:226: if (FilterStorage.subscriptions.length > 0 && !FilterStorage._loading) On 2016/03/15 13:44:22, ...
3 years, 4 months ago (2016-03-15 14:44:25 UTC) #6
Wladimir Palant
https://codereview.adblockplus.org/29338153/diff/29338339/lib/crawler.js File lib/crawler.js (right): https://codereview.adblockplus.org/29338153/diff/29338339/lib/crawler.js#newcode219 lib/crawler.js:219: FilterNotifier.addListener((action, item, newValue, oldValue) => Just realized: you have ...
3 years, 4 months ago (2016-03-15 14:50:58 UTC) #7
sergei
https://codereview.adblockplus.org/29338153/diff/29338339/lib/crawler.js File lib/crawler.js (right): https://codereview.adblockplus.org/29338153/diff/29338339/lib/crawler.js#newcode219 lib/crawler.js:219: FilterNotifier.addListener((action, item, newValue, oldValue) => On 2016/03/15 14:50:58, Wladimir ...
3 years, 4 months ago (2016-03-15 14:58:45 UTC) #8
Wladimir Palant
3 years, 4 months ago (2016-03-15 17:14:16 UTC) #9
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5