Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29338283: Issue 3499 - Use the new messaging API for the issue reporter (Closed)

Created:
March 15, 2016, 10:57 a.m. by Wladimir Palant
Modified:
March 24, 2016, 7:28 a.m.
Reviewers:
Thomas Greiner, Erik
Visibility:
Public.

Description

Issue 3499 - Use the new messaging API for the issue reporter Repository: hg.adblockplus.org/adblockplus

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -89 lines) Patch
M chrome/content/ui/sendReport.js View 1 chunk +4 lines, -2 lines 0 comments Download
M lib/child/dataCollector.js View 1 chunk +5 lines, -26 lines 0 comments Download
R lib/dataCollector.js View 1 chunk +0 lines, -61 lines 0 comments Download

Messages

Total messages: 3
Wladimir Palant
March 15, 2016, 10:57 a.m. (2016-03-15 10:57:59 UTC) #1
Erik
On 2016/03/15 10:57:59, Wladimir Palant wrote: LGTM
March 15, 2016, 8:59 p.m. (2016-03-15 20:59:28 UTC) #2
Thomas Greiner
March 23, 2016, 5:11 p.m. (2016-03-23 17:11:31 UTC) #3
LGTM

It's interesting that `Port.emitWithResponse().then()` basically acts like the
upcoming `Promise.finally()`. No objections about it at this point but still
worth noting.

Powered by Google App Engine
This is Rietveld