Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(61)

Issue 29338412: Issue 3810 - Remove hardcoded default mirror list from Malware Domains List conversion script (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 11 months ago by Vasily Kuznetsov
Modified:
3 years, 11 months ago
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 3810 - Remove hardcoded default mirror list from Malware Domains List conversion script

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename mirror_list to mirrors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -14 lines) Patch
M sitescripts/subscriptions/bin/updateMalwareDomainsList.py View 1 1 chunk +4 lines, -14 lines 0 comments Download

Messages

Total messages: 4
Vasily Kuznetsov
Let's have this ready for when the config changes are done.
3 years, 11 months ago (2016-03-16 11:26:05 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29338412/diff/29338413/sitescripts/subscriptions/bin/updateMalwareDomainsList.py File sitescripts/subscriptions/bin/updateMalwareDomainsList.py (right): https://codereview.adblockplus.org/29338412/diff/29338413/sitescripts/subscriptions/bin/updateMalwareDomainsList.py#newcode45 sitescripts/subscriptions/bin/updateMalwareDomainsList.py:45: mirrors_list = config.get(section, 'malwaredomains_mirrors').split() I guess we can call ...
3 years, 11 months ago (2016-03-16 11:27:34 UTC) #2
Vasily Kuznetsov
https://codereview.adblockplus.org/29338412/diff/29338413/sitescripts/subscriptions/bin/updateMalwareDomainsList.py File sitescripts/subscriptions/bin/updateMalwareDomainsList.py (right): https://codereview.adblockplus.org/29338412/diff/29338413/sitescripts/subscriptions/bin/updateMalwareDomainsList.py#newcode45 sitescripts/subscriptions/bin/updateMalwareDomainsList.py:45: mirrors_list = config.get(section, 'malwaredomains_mirrors').split() On 2016/03/16 11:27:34, Sebastian Noack ...
3 years, 11 months ago (2016-03-16 11:56:59 UTC) #3
Sebastian Noack
3 years, 11 months ago (2016-03-16 11:58:59 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5