Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(160)

Issue 29338430: Noissue - Fix messageResponder for Firefox (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 7 months ago by Wladimir Palant
Modified:
3 years, 7 months ago
Reviewers:
Sebastian Noack
CC:
Thomas Greiner
Visibility:
Public.

Description

Noissue - Fix messageResponder for Firefox Repository: hg.adblockplus.org/adblockplusui/

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M messageResponder.js View 2 chunks +11 lines, -2 lines 2 comments Download

Messages

Total messages: 3
Wladimir Palant
3 years, 7 months ago (2016-03-16 13:44:27 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29338430/diff/29338431/messageResponder.js File messageResponder.js (right): https://codereview.adblockplus.org/29338430/diff/29338431/messageResponder.js#newcode367 messageResponder.js:367: var subscriptions = message.url ? [Subscription.fromURL(message.url)] : What is ...
3 years, 7 months ago (2016-03-16 13:47:46 UTC) #2
Wladimir Palant
3 years, 7 months ago (2016-03-16 13:57:49 UTC) #3
https://codereview.adblockplus.org/29338430/diff/29338431/messageResponder.js
File messageResponder.js (right):

https://codereview.adblockplus.org/29338430/diff/29338431/messageResponder.js...
messageResponder.js:367: var subscriptions = message.url ?
[Subscription.fromURL(message.url)] :
On 2016/03/16 13:47:45, Sebastian Noack wrote:
> What is the change here?

Trailing whitespace removed, my editor does this automatically.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5