Issue 29338486: Issue 3822 - Fix strict-mode in generated modules

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29338486: Issue 3822 - Fix strict-mode in generated modules (Closed)

Created:
March 17, 2016, 1:42 p.m. by Sebastian Noack

Modified:
March 17, 2016, 4:12 p.m.

Reviewers:
kzar

Visibility:
Public.

Description

Issue 3822 - Fix strict-mode in generated modules

Patch Set 2 : Wrapped long line #

Created: March 17, 2016, 2:08 p.m.

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	scripts/abprewrite.js	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

kzar

https://codereview.adblockplus.org/29338486/diff/29338489/scripts/abprewrite.js File scripts/abprewrite.js (right): https://codereview.adblockplus.org/29338486/diff/29338489/scripts/abprewrite.js#newcode561 scripts/abprewrite.js:561: decompileAST(ast).replace(/^("use strict";\n)?/, "$1var exports = {};\n") + I guess ...

March 17, 2016, 1:56 p.m. (2016-03-17 13:56:47 UTC) #2

Sebastian Noack

March 17, 2016, 2:10 p.m. (2016-03-17 14:10:26 UTC) #3

kzar

LGTM (Did you test that this doesn't break things as strict mode wasn't being enforced ...

March 17, 2016, 2:14 p.m. (2016-03-17 14:14:28 UTC) #4

Sebastian Noack

March 17, 2016, 4:12 p.m. (2016-03-17 16:12:11 UTC) #5

On 2016/03/17 14:14:28, kzar wrote:
> LGTM
> 
> (Did you test that this doesn't break things as strict mode wasn't being
> enforced before?)

I did test it as good as I could with reasonable effort. But yeah, given where
we already use strict-mode meanwhile, covering every single line of code
effected is virtually impossible. Let's hope that if this uncovers any issues,
we will find them before the next release. ;)

Expand All Messages | Collapse All Messages