Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29338529: Issue 3824 - Move "use strict" into IIFE for compatibility with Kitt (Closed)

Created:
March 17, 2016, 3:57 p.m. by Sebastian Noack
Modified:
March 18, 2016, 6:45 p.m.
Reviewers:
kzar
Visibility:
Public.

Description

Issue 3824 - Move "use strict" into IIFE for compatibility with Kitt

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M lib/polyfills/fetch.js View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/polyfills/promise.js View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/polyfills/url.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
March 17, 2016, 3:57 p.m. (2016-03-17 15:57:58 UTC) #1
kzar
Shouldn't we do this consistently? For example what about chrome/ext/devtools.js?
March 18, 2016, 3:32 p.m. (2016-03-18 15:32:55 UTC) #2
Sebastian Noack
On 2016/03/18 15:32:55, kzar wrote: > Shouldn't we do this consistently? For example what about ...
March 18, 2016, 5:48 p.m. (2016-03-18 17:48:03 UTC) #3
kzar
March 18, 2016, 6:39 p.m. (2016-03-18 18:39:25 UTC) #4
Fair enough, LGTM

Powered by Google App Engine
This is Rietveld