Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29338608: Issue 3834 - Expose URL constructor to modules (Closed)

Created:
March 18, 2016, 12:11 p.m. by Wladimir Palant
Modified:
March 18, 2016, 2:10 p.m.
Reviewers:
saroyanm
CC:
Sebastian Noack
Visibility:
Public.

Description

Issue 3834 - Expose URL constructor to modules Repository: hg.adblockplus.org/buildtools

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -12 lines) Patch
M bootstrap.js.tmpl View 2 chunks +8 lines, -12 lines 2 comments Download

Messages

Total messages: 5
Wladimir Palant
March 18, 2016, 12:11 p.m. (2016-03-18 12:11:33 UTC) #1
Wladimir Palant
Forgot to CC Sebastian here, fixed now.
March 18, 2016, 12:12 p.m. (2016-03-18 12:12:57 UTC) #2
saroyanm
https://codereview.adblockplus.org/29338608/diff/29338609/bootstrap.js.tmpl File bootstrap.js.tmpl (right): https://codereview.adblockplus.org/29338608/diff/29338609/bootstrap.js.tmpl#newcode148 bootstrap.js.tmpl:148: Cc, Ci, Cr, Cu, atob, btoa, File, URL, require, ...
March 18, 2016, 1:25 p.m. (2016-03-18 13:25:44 UTC) #3
Wladimir Palant
https://codereview.adblockplus.org/29338608/diff/29338609/bootstrap.js.tmpl File bootstrap.js.tmpl (right): https://codereview.adblockplus.org/29338608/diff/29338609/bootstrap.js.tmpl#newcode148 bootstrap.js.tmpl:148: Cc, Ci, Cr, Cu, atob, btoa, File, URL, require, ...
March 18, 2016, 1:33 p.m. (2016-03-18 13:33:47 UTC) #4
saroyanm
March 18, 2016, 1:45 p.m. (2016-03-18 13:45:04 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld