Issue 3836 - Don't set DownloadableSubscription.upgradeRequired in Synchronizer

lib/synchronizer.js

Index: lib/synchronizer.js
===================================================================
--- a/lib/synchronizer.js
+++ b/lib/synchronizer.js
@@ -234,25 +234,20 @@ var Synchronizer = exports.Synchronizer 
           expirationInterval = interval * MILLIS_IN_DAY;
       }
     }
 
     let [softExpiration, hardExpiration] = downloader.processExpirationInterval(expirationInterval);
     subscription.softExpiration = Math.round(softExpiration / MILLIS_IN_SECOND);
     subscription.expires = Math.round(hardExpiration / MILLIS_IN_SECOND);
 
-    delete subscription.requiredVersion;
-    delete subscription.upgradeRequired;
     if (minVersion)
-    {
-      let {addonVersion} = require("info");
       subscription.requiredVersion = minVersion;
-      if (Services.vc.compare(minVersion, addonVersion) > 0)
-        subscription.upgradeRequired = true;
-    }
+    else
+      delete subscription.requiredVersion;
 
     // Process filters
     lines.shift();
     let filters = [];
     for (let line of lines)
     {
       line = Filter.normalize(line);
       if (line)