Issue 29338621: Issue 3788 - Keep track of Safari tabs without canLoad

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29338621: Issue 3788 - Keep track of Safari tabs without canLoad (Closed)

Created:
March 18, 2016, 2:21 p.m. by kzar

Modified:
March 18, 2016, 8:05 p.m.

Reviewers:
Sebastian Noack

Visibility:
Public.

Description

Issue 3788 - Keep track of Safari tabs without canLoad

Patch Set 2 : Strip useless "0." prefix from documentIds #

Created: March 18, 2016, 7:52 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+194 lines, -136 lines)			Patch
M	safari/ext/background.js	View		14 chunks	+150 lines, -96 lines	0 comments	Download
M	safari/ext/common.js	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	safari/ext/content.js	View	1	8 chunks	+40 lines, -40 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

kzar

Patch Set 1 https://codereview.adblockplus.org/29338621/diff/29338622/safari/ext/background.js File safari/ext/background.js (right): https://codereview.adblockplus.org/29338621/diff/29338622/safari/ext/background.js#newcode244 safari/ext/background.js:244: delete tab._documentLookup[documentId]; Is it safe to ...

March 18, 2016, 2:23 p.m. (2016-03-18 14:23:03 UTC) #1

Sebastian Noack

https://codereview.adblockplus.org/29338621/diff/29338622/safari/ext/background.js File safari/ext/background.js (right): https://codereview.adblockplus.org/29338621/diff/29338622/safari/ext/background.js#newcode244 safari/ext/background.js:244: delete tab._documentLookup[documentId]; On 2016/03/18 14:23:03, kzar wrote: > Is ...

March 18, 2016, 7:32 p.m. (2016-03-18 19:32:52 UTC) #2

Sebastian Noack

Either way LGTM, prefereable with the nit addressed. But if you disagree, I wouldn't insist.

March 18, 2016, 7:36 p.m. (2016-03-18 19:36:03 UTC) #3

kzar

March 18, 2016, 7:53 p.m. (2016-03-18 19:53:38 UTC) #4

Patch Set 2 : Strip useless "0." prefix from documentIds

https://codereview.adblockplus.org/29338621/diff/29338622/safari/ext/content.js
File safari/ext/content.js (right):

https://codereview.adblockplus.org/29338621/diff/29338622/safari/ext/content....
safari/ext/content.js:38: var documentId = Math.random().toString();
On 2016/03/18 19:32:51, Sebastian Noack wrote:
> Nit: It's not important for the logic, but more an ascetic thing;
> Math.random().toString() returns a string that always starts with "0."
followed
> by a couple random digits. So the first two digits are redundant, and could
> easily be stripped:
> 
>   Math.random().toString().substr(2)

Done.

Expand All Messages | Collapse All Messages