Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29338713: Issue 3840 - Prevent websites from making collapsed elements visible again (Closed)

Created:
March 19, 2016, 2:50 p.m. by Sebastian Noack
Modified:
March 19, 2016, 3:22 p.m.
Reviewers:
kzar
Visibility:
Public.

Description

Issue 3840 - Prevent websites from making collapsed elements visible again

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed redundant space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -38 lines) Patch
M include.preload.js View 1 3 chunks +38 lines, -38 lines 0 comments Download

Messages

Total messages: 4
Sebastian Noack
March 19, 2016, 2:51 p.m. (2016-03-19 14:51:03 UTC) #1
kzar
Otherwise LGTM https://codereview.adblockplus.org/29338713/diff/29338714/include.preload.js File include.preload.js (right): https://codereview.adblockplus.org/29338713/diff/29338714/include.preload.js#newcode18 include.preload.js:18: var MutationObserver = window.MutationObserver || window.WebKitMutationObserver; Nit: ...
March 19, 2016, 3:05 p.m. (2016-03-19 15:05:20 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29338713/diff/29338714/include.preload.js File include.preload.js (right): https://codereview.adblockplus.org/29338713/diff/29338714/include.preload.js#newcode18 include.preload.js:18: var MutationObserver = window.MutationObserver || window.WebKitMutationObserver; On 2016/03/19 15:05:20, ...
March 19, 2016, 3:12 p.m. (2016-03-19 15:12:21 UTC) #3
kzar
March 19, 2016, 3:14 p.m. (2016-03-19 15:14:37 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld