Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(394)

Issue 29338928: Issue 3853 - Use new messaging API for the first-run page (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 10 months ago by Wladimir Palant
Modified:
3 years, 9 months ago
Reviewers:
Thomas Greiner
CC:
Erik
Visibility:
Public.

Description

Issue 3853 - Use new messaging API for the first-run page Repository: hg.adblockplus.org/adblockplus

Patch Set 1 #

Total comments: 11

Patch Set 2 : Using Symbol for internal property #

Total comments: 2

Patch Set 3 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -221 lines) Patch
M ext/background.js View 1 chunk +16 lines, -40 lines 0 comments Download
M ext/common.js View 1 2 1 chunk +47 lines, -119 lines 0 comments Download
M ext/content.js View 1 chunk +51 lines, -10 lines 0 comments Download
M lib/child/cssProperties.js View 1 1 chunk +4 lines, -4 lines 0 comments Download
R lib/cssProperties.js View 1 chunk +0 lines, -47 lines 0 comments Download
M lib/main.js View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6
Wladimir Palant
3 years, 10 months ago (2016-03-22 13:54:52 UTC) #1
Thomas Greiner
Looks good, just some minor remarks. https://codereview.adblockplus.org/29338928/diff/29338929/ext/common.js File ext/common.js (right): https://codereview.adblockplus.org/29338928/diff/29338929/ext/common.js#newcode43 ext/common.js:43: var EventTarget = ...
3 years, 9 months ago (2016-04-18 13:22:50 UTC) #2
Wladimir Palant
https://codereview.adblockplus.org/29338928/diff/29338929/ext/common.js File ext/common.js (right): https://codereview.adblockplus.org/29338928/diff/29338929/ext/common.js#newcode43 ext/common.js:43: var EventTarget = global.ext._EventTarget = function(port, windowID) On 2016/04/18 ...
3 years, 9 months ago (2016-04-18 15:28:56 UTC) #3
Thomas Greiner
https://codereview.adblockplus.org/29338928/diff/29338929/ext/common.js File ext/common.js (right): https://codereview.adblockplus.org/29338928/diff/29338929/ext/common.js#newcode51 ext/common.js:51: var wrapper = (message, sender) => On 2016/04/18 15:28:56, ...
3 years, 9 months ago (2016-04-18 17:47:15 UTC) #4
Wladimir Palant
https://codereview.adblockplus.org/29338928/diff/29338929/ext/common.js File ext/common.js (right): https://codereview.adblockplus.org/29338928/diff/29338929/ext/common.js#newcode51 ext/common.js:51: var wrapper = (message, sender) => On 2016/04/18 17:47:14, ...
3 years, 9 months ago (2016-04-19 11:57:28 UTC) #5
Thomas Greiner
3 years, 9 months ago (2016-04-19 12:06:07 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5