Issue 3862 - Make filterListener use the new FilterNotifier API

lib/filterListener.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 96 matching lines @@
 /**
  * Initializes filter listener on startup, registers the necessary hooks.
  */
 function init()
 {
   FilterNotifier.on("filter.hitCount", onFilterHitCount);
   FilterNotifier.on("filter.lastHit", onFilterLastHit);
   FilterNotifier.on("filter.added", onFilterAdded);
   FilterNotifier.on("filter.removed", onFilterRemoved);
   FilterNotifier.on("filter.disabled", onFilterDisabled);
+  FilterNotifier.on("filter.moved", onGenericChange);
 
   FilterNotifier.on("subscription.added", onSubscriptionAdded);
   FilterNotifier.on("subscription.removed", onSubscriptionRemoved);
   FilterNotifier.on("subscription.disabled", onSubscriptionDisabled);
   FilterNotifier.on("subscription.updated", onSubscriptionUpdated);
+  FilterNotifier.on("subscription.moved", onGenericChange);
+  FilterNotifier.on("subscription.title", onGenericChange);
+  FilterNotifier.on("subscription.fixedTitle", onGenericChange);
+  FilterNotifier.on("subscription.homepage", onGenericChange);
+  FilterNotifier.on("subscription.downloadStatus", onGenericChange);
+  FilterNotifier.on("subscription.lastCheck", onGenericChange);
+  FilterNotifier.on("subscription.errors", onGenericChange);
 
   FilterNotifier.on("load", onLoad);
   FilterNotifier.on("save", onSave);
 
 
   if ("nsIStyleSheetService" in Ci)
     ElemHide.init();
   else
     flushElemHide = function() {};    // No global stylesheet in Chrome & Co.
   FilterStorage.loadFromDisk();
@@ skipping 71 matching lines @@
       CSSRules.remove(filter);
     else
       ElemHide.remove(filter);
   }
 }
 
 function onSubscriptionAdded(subscription)
 {
   FilterListener.setDirty(1);
 
-  if (subscription.url in FilterStorage.knownSubscriptions && !subscription.disabled)

[kzar, 2016/03/23 16:02:32]

Nit: Mind wrapping this long line?

[Wladimir Palant, 2016/03/23 16:12:39]

`subscription.url in FilterStorage.knownSubscriptions` check can be removed,
this notification means that the subscription has been added.

[Sebastian Noack, 2016/03/23 17:56:09]

Done.

+  if (!subscription.disabled)
   {
     subscription.filters.forEach(addFilter);
     flushElemHide();
   }
 }
 
 function onSubscriptionRemoved(subscription)
 {
   FilterListener.setDirty(1);
 
@@ skipping 14 matching lines @@
       subscription.filters.forEach(addFilter);
     else
       subscription.filters.forEach(removeFilter);
     flushElemHide();
   }
 }
 
 function onSubscriptionUpdated(subscription)
 {
   FilterListener.setDirty(1);
 

[kzar, 2016/03/23 16:02:32]

Nit: ... and this one.

[Sebastian Noack, 2016/03/23 17:56:09]

Done.

-  if (subscription.url in FilterStorage.knownSubscriptions && !subscription.disabled)
+  if (subscription.url in FilterStorage.knownSubscriptions &&
+      !subscription.disabled)
   {
     subscription.oldFilters.forEach(removeFilter);
     subscription.filters.forEach(addFilter);
     flushElemHide();
   }
 }
 
 function onFilterHitCount(filter, newValue)
 {
   if (newValue == 0)
@@ skipping 31 matching lines @@
 
 function onFilterDisabled(filter, newValue)
 {
   FilterListener.setDirty(1);
 
   if (newValue == false)
     addFilter(filter);
   else
     removeFilter(filter);
   flushElemHide();
+}
+
+function onGenericChange()
+{
+  FilterListener.setDirty(1);
 }
 
 function onLoad()
 {
   isDirty = 0;
 
   defaultMatcher.clear();
   ElemHide.clear();
   CSSRules.clear();
   for (let subscription of FilterStorage.subscriptions)
     if (!subscription.disabled)
       subscription.filters.forEach(addFilter);
   flushElemHide();
 }
 
 function onSave()
 {
   isDirty = 0;
 }