Issue 3862 - Make filterListener use the new FilterNotifier API

Issue 3862 - Make filterListener use the new FilterNotifier API

[kzar, 2016-03-23 16:02:32]

https://codereview.adblockplus.org/29338976/diff/29338977/lib/filterListener.js
File lib/filterListener.js (right):

https://codereview.adblockplus.org/29338976/diff/29338977/lib/filterListener....
lib/filterListener.js:213: if (subscription.url in
FilterStorage.knownSubscriptions && !subscription.disabled)
Nit: Mind wrapping this long line?

https://codereview.adblockplus.org/29338976/diff/29338977/lib/filterListener....
lib/filterListener.js:248: 
Nit: ... and this one.

[Wladimir Palant, 2016-03-23 16:12:40]

I assume that you didn't run the unit tests on this? Running them currently
requires getting this into ABP/Firefox, would be a good opportunity to convert
filterNotifier unit tests and move them here.

https://codereview.adblockplus.org/29338976/diff/29338977/lib/filterListener.js
File lib/filterListener.js (right):

https://codereview.adblockplus.org/29338976/diff/29338977/lib/filterListener....
lib/filterListener.js:213: if (subscription.url in
FilterStorage.knownSubscriptions && !subscription.disabled)
`subscription.url in FilterStorage.knownSubscriptions` check can be removed,
this notification means that the subscription has been added.

[Sebastian Noack, 2016-03-23 17:56:09]

On 2016/03/23 16:12:40, Wladimir Palant wrote:
> I assume that you didn't run the unit tests on this? Running them currently
> requires getting this into ABP/Firefox, would be a good opportunity to convert
> filterNotifier unit tests and move them here.

I only tested the changes on Chrome. However, I don't see how they could
potentially break any tests on Firefox. The filterListener modules doesn't have
any exports (that we changed). Neither should the behavior differ with these
changes. And we kept the FilterNotifier API backwards compatible. So we should
be fine.

https://codereview.adblockplus.org/29338976/diff/29338977/lib/filterListener.js
File lib/filterListener.js (right):

https://codereview.adblockplus.org/29338976/diff/29338977/lib/filterListener....
lib/filterListener.js:213: if (subscription.url in
FilterStorage.knownSubscriptions && !subscription.disabled)
On 2016/03/23 16:12:39, Wladimir Palant wrote:
> `subscription.url in FilterStorage.knownSubscriptions` check can be removed,
> this notification means that the subscription has been added.

Done.

https://codereview.adblockplus.org/29338976/diff/29338977/lib/filterListener....
lib/filterListener.js:248: 
On 2016/03/23 16:02:32, kzar wrote:
> Nit: ... and this one.

Done.

[Sebastian Noack, 2016-03-23 18:30:27]

I just realized that I missed some actions that were implicitly handled before.
New patch set is up.

[kzar, 2016-03-23 18:42:06]

LGTM